Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Side by Side Diff: device/generic_sensor/sensor_provider_impl.cc

Issue 2368193003: [sensors] Introduce asynchronous way to create sensors. (Closed)
Patch Set: Added a temporary dependency for dependent patch that is based on top of this cl. Reason: cannot ha… Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "device/generic_sensor/sensor_provider_impl.h" 5 #include "device/generic_sensor/sensor_provider_impl.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "device/generic_sensor/platform_sensor_provider.h" 9 #include "device/generic_sensor/platform_sensor_provider.h"
10 #include "device/generic_sensor/sensor_impl.h" 10 #include "device/generic_sensor/sensor_impl.h"
11 #include "mojo/public/cpp/bindings/strong_binding.h" 11 #include "mojo/public/cpp/bindings/strong_binding.h"
12 12
13 namespace device { 13 namespace device {
14 14
15 namespace { 15 namespace {
16 16
17 uint64_t GetBufferOffset(mojom::SensorType type) { 17 uint64_t GetBufferOffset(mojom::SensorType type) {
18 return (static_cast<uint64_t>(mojom::SensorType::LAST) - 18 return (static_cast<uint64_t>(mojom::SensorType::LAST) -
19 static_cast<uint64_t>(type)) * 19 static_cast<uint64_t>(type)) *
20 mojom::SensorInitParams::kReadBufferSize; 20 mojom::SensorInitParams::kReadBufferSize;
21 } 21 }
22 22
23 using CreateSensorCallback =
24 base::Callback<void(scoped_refptr<PlatformSensor>)>;
25
23 } // namespace 26 } // namespace
24 27
25 // static 28 // static
26 void SensorProviderImpl::Create(mojom::SensorProviderRequest request) { 29 void SensorProviderImpl::Create(mojom::SensorProviderRequest request) {
27 PlatformSensorProvider* provider = PlatformSensorProvider::GetInstance(); 30 PlatformSensorProvider* provider = PlatformSensorProvider::GetInstance();
28 if (provider) { 31 if (provider) {
29 mojo::MakeStrongBinding(base::WrapUnique(new SensorProviderImpl(provider)), 32 mojo::MakeStrongBinding(base::WrapUnique(new SensorProviderImpl(provider)),
30 std::move(request)); 33 std::move(request));
31 } 34 }
32 } 35 }
33 36
34 SensorProviderImpl::SensorProviderImpl(PlatformSensorProvider* provider) 37 SensorProviderImpl::SensorProviderImpl(PlatformSensorProvider* provider)
35 : provider_(provider) { 38 : provider_(provider), weak_ptr_factory_(this) {
36 DCHECK(provider_); 39 DCHECK(provider_);
37 } 40 }
38 41
39 SensorProviderImpl::~SensorProviderImpl() {} 42 SensorProviderImpl::~SensorProviderImpl() {}
40 43
41 void SensorProviderImpl::GetSensor(mojom::SensorType type, 44 void SensorProviderImpl::GetSensor(mojom::SensorType type,
42 mojom::SensorRequest sensor_request, 45 mojom::SensorRequest sensor_request,
43 const GetSensorCallback& callback) { 46 const GetSensorCallback& callback) {
44 auto cloned_handle = provider_->CloneSharedBufferHandle(); 47 auto cloned_handle = provider_->CloneSharedBufferHandle();
45 if (!cloned_handle.is_valid()) { 48 if (!cloned_handle.is_valid()) {
46 callback.Run(nullptr, nullptr); 49 callback.Run(nullptr, nullptr);
47 return; 50 return;
48 } 51 }
49 52
50 scoped_refptr<PlatformSensor> sensor = provider_->GetSensor(type); 53 scoped_refptr<PlatformSensor> sensor = provider_->GetSensor(type);
51 if (!sensor) { 54 if (!sensor) {
52 sensor = provider_->CreateSensor( 55 CreateSensorCallback cb = base::Bind(
53 type, mojom::SensorInitParams::kReadBufferSize, GetBufferOffset(type)); 56 &SensorProviderImpl::SensorCreated, weak_ptr_factory_.GetWeakPtr(),
57 type, base::Passed(&cloned_handle), base::Passed(&sensor_request),
58 callback);
59 provider_->CreateSensor(type, mojom::SensorInitParams::kReadBufferSize,
60 GetBufferOffset(type), cb);
61 return;
54 } 62 }
55 63
64 SensorCreated(type, std::move(cloned_handle), std::move(sensor_request),
65 callback, std::move(sensor));
66 }
67
68 void SensorProviderImpl::SensorCreated(
69 mojom::SensorType type,
70 mojo::ScopedSharedBufferHandle cloned_handle,
71 mojom::SensorRequest sensor_request,
72 const GetSensorCallback& callback,
73 scoped_refptr<PlatformSensor> sensor) {
56 if (!sensor) { 74 if (!sensor) {
57 callback.Run(nullptr, nullptr); 75 callback.Run(nullptr, nullptr);
58 return; 76 return;
59 } 77 }
60 78
61 auto sensor_impl = base::MakeUnique<SensorImpl>(sensor); 79 auto sensor_impl = base::MakeUnique<SensorImpl>(sensor);
62 80
63 auto init_params = mojom::SensorInitParams::New(); 81 auto init_params = mojom::SensorInitParams::New();
64 init_params->memory = std::move(cloned_handle); 82 init_params->memory = std::move(cloned_handle);
65 init_params->buffer_offset = GetBufferOffset(type); 83 init_params->buffer_offset = GetBufferOffset(type);
66 init_params->mode = sensor->GetReportingMode(); 84 init_params->mode = sensor->GetReportingMode();
67 init_params->default_configuration = sensor->GetDefaultConfiguration(); 85 init_params->default_configuration = sensor->GetDefaultConfiguration();
68 86
69 callback.Run(std::move(init_params), sensor_impl->GetClient()); 87 callback.Run(std::move(init_params), sensor_impl->GetClient());
70 88
71 mojo::MakeStrongBinding(std::move(sensor_impl), std::move(sensor_request)); 89 mojo::MakeStrongBinding(std::move(sensor_impl), std::move(sensor_request));
72 } 90 }
73 91
74 } // namespace device 92 } // namespace device
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698