[sensors] Introduce asynchronous way to create sensors.

device/generic_sensor/platform_sensor_provider_base.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "device/generic_sensor/platform_sensor_provider_base.h"
 
 #include <utility>
 
 #include "base/stl_util.h"
 #include "device/generic_sensor/public/interfaces/sensor_provider.mojom.h"
 
 namespace device {
 
 namespace {
 
 const uint64_t kSharedBufferSizeInBytes =
     mojom::SensorInitParams::kReadBufferSize *
     static_cast<uint64_t>(mojom::SensorType::LAST);
 
 }  // namespace
 
 PlatformSensorProviderBase::PlatformSensorProviderBase() = default;
 PlatformSensorProviderBase::~PlatformSensorProviderBase() = default;
 
-scoped_refptr<PlatformSensor> PlatformSensorProviderBase::CreateSensor(
+void PlatformSensorProviderBase::CreateSensor(
     mojom::SensorType type,
     uint64_t size,
-    uint64_t offset) {
+    uint64_t offset,
+    const CreateSensorCallback& callback) {
   DCHECK(CalledOnValidThread());
 
-  if (!CreateSharedBufferIfNeeded())
-    return nullptr;
+  if (!CreateSharedBufferIfNeeded()) {
+    callback.Run(nullptr);
+    return;
+  }
 
   mojo::ScopedSharedBufferMapping mapping =
       shared_buffer_handle_->MapAtOffset(size, offset);
-  if (!mapping)
-    return nullptr;
+  if (!mapping) {
+    callback.Run(nullptr);
+    return;
+  }
 
-  scoped_refptr<PlatformSensor> new_sensor =
-      CreateSensorInternal(type, std::move(mapping), size);
-  if (!new_sensor)
-    return nullptr;
+  auto it = requests_map_.find(type);
+  if (it != requests_map_.end()) {
+    it->second.push_back(callback);

[timvolodine, 2016/09/27 19:39:29]

should we be worried about potential memory drain (and OOM) in case of very many
'CreateSensor' calls?

[maksims (do not use this acc), 2016/09/28 07:45:37]

Actually, no. It takes 2-3 milliseconds for a callback to come from mojo IPC and
~300 microseconds to search for a sensor.

[timvolodine, 2016/09/29 13:17:26]

hmm, even when the initial sensor creation takes a long time and requests 'pile
up' during that time?

[maksims (do not use this acc), 2016/09/30 06:23:06]

We have one proxy per frame. This scenario is unlikely. There should be a lot of
frames in order to create a huge amount of callbacks. It will  run out of memory
due to a huge number of frames rather than callbacks.

[timvolodine, 2016/09/30 18:50:48]

I see

+  } else {
+    requests_map_[type] = CallbackQueue({callback});
 
-  DCHECK(!ContainsKey(sensor_map_, type));
-  sensor_map_[type] = new_sensor.get();
-
-  return new_sensor;
+    CreateSensorInternal(
+        type, std::move(mapping), size,
+        base::Bind(&PlatformSensorProviderBase::NotifySensorCreated,
+                   base::Unretained(this), type));
+  }
 }
 
 scoped_refptr<PlatformSensor> PlatformSensorProviderBase::GetSensor(
     mojom::SensorType type) {
   DCHECK(CalledOnValidThread());
 
   auto it = sensor_map_.find(type);
   if (it != sensor_map_.end())
     return it->second;
   return nullptr;
@@ skipping 18 matching lines @@
     shared_buffer_handle_.reset();
 }
 
 mojo::ScopedSharedBufferHandle
 PlatformSensorProviderBase::CloneSharedBufferHandle() {
   DCHECK(CalledOnValidThread());
   CreateSharedBufferIfNeeded();
   return shared_buffer_handle_->Clone();
 }
 
+void PlatformSensorProviderBase::NotifySensorCreated(
+    mojom::SensorType type,
+    scoped_refptr<PlatformSensor> sensor) {
+  DCHECK(CalledOnValidThread());
+  DCHECK(!ContainsKey(sensor_map_, type));
+  DCHECK(ContainsKey(requests_map_, type));
+
+  if (sensor)
+    sensor_map_[type] = sensor.get();
+
+  // Inform subscribers about the sensor.
+  // |sensor| can be nullptr here.
+  auto it = requests_map_.find(type);
+  for (auto& cb : it->second)

[timvolodine, 2016/09/27 19:39:29]

nit: better name for cb? is it 'callback'?

[maksims (do not use this acc), 2016/09/28 07:45:37]

Done.

+    cb.Run(sensor);
+
+  requests_map_.erase(type);
+}
+
 }  // namespace device