Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 2368183005: Merged: Make sure to use the correct context for eval checks (Closed)

Created:
4 years, 2 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 2 months ago
Reviewers:
Michael Hablich
CC:
v8-reviews_googlegroups.com, v8-merges_googlegroups.com, ulan
Target Ref:
refs/pending/branch-heads/5.4
Project:
v8
Visibility:
Public.

Description

Merged: Make sure to use the correct context for eval checks Revision: d008b9efcbddf299feefe7b420fd7e1601512ba5 BUG=chromium:635769 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true TBR=hablich@chromium.org Committed: https://chromium.googlesource.com/v8/v8/+/f1ac92a6f388f707b9eff32690560d5a73d5ee5d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -6 lines) Patch
M src/api.h View 5 chunks +10 lines, -0 lines 0 comments Download
M src/builtins/builtins.cc View 1 chunk +5 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
jochen (gone - plz use gerrit)
4 years, 2 months ago (2016-09-27 11:14:47 UTC) #1
jochen (gone - plz use gerrit)
NOTE: This script will no longer automatically update include/v8-version.h and create a tag. This is ...
4 years, 2 months ago (2016-09-27 11:14:49 UTC) #2
jochen (gone - plz use gerrit)
Committed patchset #1 (id:1) manually as f1ac92a6f388f707b9eff32690560d5a73d5ee5d.
4 years, 2 months ago (2016-09-27 11:16:19 UTC) #4
Michael Hablich
4 years, 2 months ago (2016-09-28 12:33:09 UTC) #5
Message was sent while issue was closed.
On 2016/09/27 11:16:19, jochen (slow) wrote:
> Committed patchset #1 (id:1) manually as
> f1ac92a6f388f707b9eff32690560d5a73d5ee5d.

lgtm

Powered by Google App Engine
This is Rietveld 408576698