Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Unified Diff: content/browser/frame_host/navigator_impl.cc

Issue 2368183004: Move redirect_chain from NavigationEntry to FrameNavigationEntry. (Closed)
Patch Set: Addressed comments. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/frame_host/navigation_entry_impl.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/frame_host/navigator_impl.cc
diff --git a/content/browser/frame_host/navigator_impl.cc b/content/browser/frame_host/navigator_impl.cc
index a25c56910565a66d44516a2022fb1c61b469ef7d..8b415b21487bdd95b335d2d2814ddc8274214ba7 100644
--- a/content/browser/frame_host/navigator_impl.cc
+++ b/content/browser/frame_host/navigator_impl.cc
@@ -820,8 +820,9 @@ void NavigatorImpl::RequestTransferURL(
}
entry->AddOrUpdateFrameEntry(
node, -1, -1, nullptr,
- static_cast<SiteInstanceImpl*>(source_site_instance), dest_url,
- referrer_to_use, PageState(), method, -1);
+ static_cast<SiteInstanceImpl*>(source_site_instance),
+ dest_url, referrer_to_use, redirect_chain, PageState(), method,
+ -1);
} else {
// Main frame case.
entry = NavigationEntryImpl::FromNavigationEntry(
@@ -830,9 +831,9 @@ void NavigatorImpl::RequestTransferURL(
std::string(), controller_->GetBrowserContext()));
entry->root_node()->frame_entry->set_source_site_instance(
static_cast<SiteInstanceImpl*>(source_site_instance));
+ entry->SetRedirectChain(redirect_chain);
}
- entry->SetRedirectChain(redirect_chain);
// Don't allow an entry replacement if there is no entry to replace.
// http://crbug.com/457149
if (should_replace_current_entry && controller_->GetEntryCount() > 0)
@@ -1149,7 +1150,8 @@ void NavigatorImpl::DidStartMainFrameNavigation(
entry->set_transferred_global_request_id(
pending_entry->transferred_global_request_id());
entry->set_should_replace_entry(pending_entry->should_replace_entry());
- entry->SetRedirectChain(pending_entry->GetRedirectChain());
+ entry->SetRedirectChain(
+ pending_entry->GetRedirectChain());
Charlie Reis 2016/09/28 17:35:14 nit: Can fit one one line.
arthursonzogni 2016/10/03 16:26:36 Done.
}
// If there's a current NavigationHandle, update its pending NavEntry ID.
« no previous file with comments | « content/browser/frame_host/navigation_entry_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698