Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1144)

Unified Diff: content/browser/frame_host/frame_navigation_entry.h

Issue 2368183004: Move redirect_chain from NavigationEntry to FrameNavigationEntry. (Closed)
Patch Set: Nit Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/frame_host/frame_navigation_entry.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/frame_host/frame_navigation_entry.h
diff --git a/content/browser/frame_host/frame_navigation_entry.h b/content/browser/frame_host/frame_navigation_entry.h
index 861dcc46ba1d8ea7cbcb04f36fd0310dc5435b51..eca2712e788460b4eed86682a92671bf4521949e 100644
--- a/content/browser/frame_host/frame_navigation_entry.h
+++ b/content/browser/frame_host/frame_navigation_entry.h
@@ -53,6 +53,7 @@ class CONTENT_EXPORT FrameNavigationEntry
scoped_refptr<SiteInstanceImpl> source_site_instance,
const GURL& url,
const Referrer& referrer,
+ const std::vector<GURL>& redirect_chain,
const PageState& page_state,
const std::string& method,
int64_t post_id);
@@ -110,6 +111,13 @@ class CONTENT_EXPORT FrameNavigationEntry
void set_referrer(const Referrer& referrer) { referrer_ = referrer; }
const Referrer& referrer() const { return referrer_; }
+ // The redirect chain traversed during this frame navigation, from the initial
+ // redirecting URL to the final non-redirecting current URL.
+ void set_redirect_chain(const std::vector<GURL>& redirect_chain) {
+ redirect_chain_ = redirect_chain;
+ }
+ const std::vector<GURL>& redirect_chain() const { return redirect_chain_; }
+
void SetPageState(const PageState& page_state);
const PageState& page_state() const { return page_state_; }
@@ -145,6 +153,11 @@ class CONTENT_EXPORT FrameNavigationEntry
scoped_refptr<SiteInstanceImpl> source_site_instance_;
GURL url_;
Referrer referrer_;
+ // This is used when transferring a pending entry from one process to another.
+ // We also send the main frame's redirect chain through session sync for
+ // offline analysis.
+ // It is preserved after commit but should not be persisted.
+ std::vector<GURL> redirect_chain_;
// TODO(creis): Change this to FrameState.
PageState page_state_;
std::string method_;
« no previous file with comments | « no previous file | content/browser/frame_host/frame_navigation_entry.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698