Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(893)

Unified Diff: content/browser/frame_host/navigation_entry_impl.h

Issue 2368183004: Move redirect_chain from NavigationEntry to FrameNavigationEntry. (Closed)
Patch Set: Add tests + bugfix. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigation_entry_impl.h
diff --git a/content/browser/frame_host/navigation_entry_impl.h b/content/browser/frame_host/navigation_entry_impl.h
index beb9a769fd5261cb3b41b867386da8270745b46e..c3b39a938f03fd90d14154793222ed223d022f6a 100644
--- a/content/browser/frame_host/navigation_entry_impl.h
+++ b/content/browser/frame_host/navigation_entry_impl.h
@@ -224,6 +224,7 @@ class CONTENT_EXPORT NavigationEntryImpl
scoped_refptr<SiteInstanceImpl> source_site_instance,
const GURL& url,
const Referrer& referrer,
+ const std::vector<GURL>& redirect_chain,
const PageState& page_state,
const std::string& method,
int64_t post_id);
@@ -502,11 +503,6 @@ class CONTENT_EXPORT NavigationEntryImpl
// doing the redirect).
bool should_replace_entry_;
- // This is used when transferring a pending entry from one process to another.
- // We also send this data through session sync for offline analysis.
- // It is preserved after commit but should not be persisted.
- std::vector<GURL> redirect_chain_;
-
// This is set to true when this entry's navigation should clear the session
// history both on the renderer and browser side. The browser side history
// won't be cleared until the renderer has committed this navigation. This

Powered by Google App Engine
This is Rietveld 408576698