Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Unified Diff: content/browser/frame_host/navigation_entry_impl.h

Issue 2368183004: Move redirect_chain from NavigationEntry to FrameNavigationEntry. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigation_entry_impl.h
diff --git a/content/browser/frame_host/navigation_entry_impl.h b/content/browser/frame_host/navigation_entry_impl.h
index fa2c88e9614ec8db0e57e2a3d5ee221c228e1203..4c7814e25ab0d115aeba29525c795e31fdad5d67 100644
--- a/content/browser/frame_host/navigation_entry_impl.h
+++ b/content/browser/frame_host/navigation_entry_impl.h
@@ -143,8 +143,8 @@ class CONTENT_EXPORT NavigationEntryImpl
void ClearExtraData(const std::string& key) override;
void SetHttpStatusCode(int http_status_code) override;
int GetHttpStatusCode() const override;
- void SetRedirectChain(const std::vector<GURL>& redirects) override;
- const std::vector<GURL>& GetRedirectChain() const override;
+ void SetMainFrameRedirectChain(const std::vector<GURL>& redirects) override;
+ const std::vector<GURL>& GetMainFrameRedirectChain() const override;
bool IsRestored() const override;
// Creates a copy of this NavigationEntryImpl that can be modified
@@ -219,6 +219,7 @@ class CONTENT_EXPORT NavigationEntryImpl
int64_t document_sequence_number,
SiteInstanceImpl* site_instance,
scoped_refptr<SiteInstanceImpl> source_site_instance,
+ const std::vector<GURL>& redirect_chain,
const GURL& url,
const Referrer& referrer,
const PageState& page_state,
@@ -483,11 +484,6 @@ class CONTENT_EXPORT NavigationEntryImpl
// doing the redirect).
bool should_replace_entry_;
- // This is used when transferring a pending entry from one process to another.
- // We also send this data through session sync for offline analysis.
- // It is preserved after commit but should not be persisted.
- std::vector<GURL> redirect_chain_;
-
// This is set to true when this entry's navigation should clear the session
// history both on the renderer and browser side. The browser side history
// won't be cleared until the renderer has committed this navigation. This

Powered by Google App Engine
This is Rietveld 408576698