Move redirect_chain from NavigationEntry to FrameNavigationEntry.

content/browser/frame_host/frame_navigation_entry.h

Index: content/browser/frame_host/frame_navigation_entry.h
diff --git a/content/browser/frame_host/frame_navigation_entry.h b/content/browser/frame_host/frame_navigation_entry.h
index 861dcc46ba1d8ea7cbcb04f36fd0310dc5435b51..d0f2ed53f6379783c21c767ca335eea9a5495323 100644
--- a/content/browser/frame_host/frame_navigation_entry.h
+++ b/content/browser/frame_host/frame_navigation_entry.h
@@ -51,6 +51,7 @@ class CONTENT_EXPORT FrameNavigationEntry
                    int64_t document_sequence_number,
                    SiteInstanceImpl* site_instance,
                    scoped_refptr<SiteInstanceImpl> source_site_instance,
+                   const std::vector<GURL>& redirect_chain,

[Charlie Reis, 2016/09/28 04:13:17]

Throughout this file, we should list redirect_chain lower among the other
parameters/members, perhaps between referrer and page_state.

[arthursonzogni, 2016/09/28 16:36:14]

Done.

                    const GURL& url,
                    const Referrer& referrer,
                    const PageState& page_state,
@@ -101,6 +102,13 @@ class CONTENT_EXPORT FrameNavigationEntry
     return source_site_instance_.get();
   }
 
+  // The redirect chain traversed during this frame navigation, from the initial
+  // redirecting URL to the final non-redirecting current URL.
+  void set_redirect_chain(const std::vector<GURL>& redirect_chain) {
+    redirect_chain_ = redirect_chain;
+  }
+  const std::vector<GURL>& redirect_chain() const { return redirect_chain_; }
+
   // The actual URL loaded in the frame.  This is in contrast to the virtual
   // URL, which is shown to the user.
   void set_url(const GURL& url) { url_ = url; }
@@ -143,6 +151,12 @@ class CONTENT_EXPORT FrameNavigationEntry
   scoped_refptr<SiteInstanceImpl> site_instance_;
   // This member is cleared at commit time and is not persisted.
   scoped_refptr<SiteInstanceImpl> source_site_instance_;
+
+  // This is used when transferring a pending entry from one process to another.
+  // We also send this data through session sync for offline analysis.
+  // It is preserved after commit but should not be persisted.
+  std::vector<GURL> redirect_chain_;

[arthursonzogni, 2016/09/27 12:56:20]

I am not sure of the comment message. Which sentences are still necessary and
correct?

[Charlie Reis, 2016/09/28 04:13:17]

The first sentence is still true (see NavigatorImpl::RequestTransferURL for
transfers, and NavigationControllerImpl::LoadURLWithParams for OpenURL).

The second sentence is only true for main frames, so let's clarify that.  (See
ContentSerializedNavigationBuilder::FromNavigationEntry.)

The third sentence is still true.

nit: As above, let's move this down between referrer_ and page_state_.

[arthursonzogni, 2016/09/28 16:36:14]

Thanks!

+
   GURL url_;
   Referrer referrer_;
   // TODO(creis): Change this to FrameState.