Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Side by Side Diff: components/sessions/content/content_serialized_navigation_builder.cc

Issue 2368183004: Move redirect_chain from NavigationEntry to FrameNavigationEntry. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/sessions/content/content_serialized_navigation_builder.h" 5 #include "components/sessions/content/content_serialized_navigation_builder.h"
6 6
7 #include "components/sessions/content/content_record_password_state.h" 7 #include "components/sessions/content/content_record_password_state.h"
8 #include "components/sessions/core/serialized_navigation_entry.h" 8 #include "components/sessions/core/serialized_navigation_entry.h"
9 #include "content/public/browser/browser_context.h" 9 #include "content/public/browser/browser_context.h"
10 #include "content/public/browser/favicon_status.h" 10 #include "content/public/browser/favicon_status.h"
(...skipping 21 matching lines...) Expand all
32 navigation.has_post_data_ = entry.GetHasPostData(); 32 navigation.has_post_data_ = entry.GetHasPostData();
33 navigation.post_id_ = entry.GetPostID(); 33 navigation.post_id_ = entry.GetPostID();
34 navigation.original_request_url_ = entry.GetOriginalRequestURL(); 34 navigation.original_request_url_ = entry.GetOriginalRequestURL();
35 navigation.is_overriding_user_agent_ = entry.GetIsOverridingUserAgent(); 35 navigation.is_overriding_user_agent_ = entry.GetIsOverridingUserAgent();
36 navigation.timestamp_ = entry.GetTimestamp(); 36 navigation.timestamp_ = entry.GetTimestamp();
37 navigation.is_restored_ = entry.IsRestored(); 37 navigation.is_restored_ = entry.IsRestored();
38 entry.GetExtraData(kSearchTermsKey, &navigation.search_terms_); 38 entry.GetExtraData(kSearchTermsKey, &navigation.search_terms_);
39 if (entry.GetFavicon().valid) 39 if (entry.GetFavicon().valid)
40 navigation.favicon_url_ = entry.GetFavicon().url; 40 navigation.favicon_url_ = entry.GetFavicon().url;
41 navigation.http_status_code_ = entry.GetHttpStatusCode(); 41 navigation.http_status_code_ = entry.GetHttpStatusCode();
42 navigation.redirect_chain_ = entry.GetRedirectChain(); 42 navigation.redirect_chain_ = entry.GetMainFrameRedirectChain();
43 navigation.password_state_ = GetPasswordStateFromNavigation(entry); 43 navigation.password_state_ = GetPasswordStateFromNavigation(entry);
44 44
45 return navigation; 45 return navigation;
46 } 46 }
47 47
48 // static 48 // static
49 std::unique_ptr<content::NavigationEntry> 49 std::unique_ptr<content::NavigationEntry>
50 ContentSerializedNavigationBuilder::ToNavigationEntry( 50 ContentSerializedNavigationBuilder::ToNavigationEntry(
51 const SerializedNavigationEntry* navigation, 51 const SerializedNavigationEntry* navigation,
52 int page_id, 52 int page_id,
(...skipping 16 matching lines...) Expand all
69 entry->SetPageState(content::PageState::CreateFromEncodedData( 69 entry->SetPageState(content::PageState::CreateFromEncodedData(
70 navigation->encoded_page_state_)); 70 navigation->encoded_page_state_));
71 entry->SetPageID(page_id); 71 entry->SetPageID(page_id);
72 entry->SetHasPostData(navigation->has_post_data_); 72 entry->SetHasPostData(navigation->has_post_data_);
73 entry->SetPostID(navigation->post_id_); 73 entry->SetPostID(navigation->post_id_);
74 entry->SetOriginalRequestURL(navigation->original_request_url_); 74 entry->SetOriginalRequestURL(navigation->original_request_url_);
75 entry->SetIsOverridingUserAgent(navigation->is_overriding_user_agent_); 75 entry->SetIsOverridingUserAgent(navigation->is_overriding_user_agent_);
76 entry->SetTimestamp(navigation->timestamp_); 76 entry->SetTimestamp(navigation->timestamp_);
77 entry->SetExtraData(kSearchTermsKey, navigation->search_terms_); 77 entry->SetExtraData(kSearchTermsKey, navigation->search_terms_);
78 entry->SetHttpStatusCode(navigation->http_status_code_); 78 entry->SetHttpStatusCode(navigation->http_status_code_);
79 entry->SetRedirectChain(navigation->redirect_chain_); 79 entry->SetMainFrameRedirectChain(navigation->redirect_chain_);
80 80
81 // These fields should have default values. 81 // These fields should have default values.
82 DCHECK_EQ(SerializedNavigationEntry::STATE_INVALID, 82 DCHECK_EQ(SerializedNavigationEntry::STATE_INVALID,
83 navigation->blocked_state_); 83 navigation->blocked_state_);
84 DCHECK_EQ(0u, navigation->content_pack_categories_.size()); 84 DCHECK_EQ(0u, navigation->content_pack_categories_.size());
85 85
86 return entry; 86 return entry;
87 } 87 }
88 88
89 // static 89 // static
90 std::vector<std::unique_ptr<content::NavigationEntry>> 90 std::vector<std::unique_ptr<content::NavigationEntry>>
91 ContentSerializedNavigationBuilder::ToNavigationEntries( 91 ContentSerializedNavigationBuilder::ToNavigationEntries(
92 const std::vector<SerializedNavigationEntry>& navigations, 92 const std::vector<SerializedNavigationEntry>& navigations,
93 content::BrowserContext* browser_context) { 93 content::BrowserContext* browser_context) {
94 int page_id = 0; 94 int page_id = 0;
95 std::vector<std::unique_ptr<content::NavigationEntry>> entries; 95 std::vector<std::unique_ptr<content::NavigationEntry>> entries;
96 entries.reserve(navigations.size()); 96 entries.reserve(navigations.size());
97 for (const auto& navigation : navigations) { 97 for (const auto& navigation : navigations) {
98 entries.push_back(ToNavigationEntry(&navigation, page_id, browser_context)); 98 entries.push_back(ToNavigationEntry(&navigation, page_id, browser_context));
99 ++page_id; 99 ++page_id;
100 } 100 }
101 return entries; 101 return entries;
102 } 102 }
103 103
104 } // namespace sessions 104 } // namespace sessions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698