third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc - Issue 2368153003: Compute margin block start for 1st block in LayoutNG root constraint space

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc

Issue 2368153003: Compute margin block start for 1st block in LayoutNG root constraint space (Closed)

Patch Set: Get IsNewBfc from layout_box->createsNewFormattingContext() Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc ('k') | third_party/WebKit/Source/core/layout/ng/ng_box.cc » ('j') | third_party/WebKit/Source/core/layout/ng/ng_box.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc

diff --git a/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc b/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc

index d1c93cbd268b649d2071ee1488b7772c7ce6325f..2812335e2b779a27730a43bb1211c5f73d4a618d 100644

--- a/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc

+++ b/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc

@@ -19,7 +19,7 @@ class NGBlockLayoutAlgorithmTest : public ::testing::Test {

protected:

void SetUp() override { style_ = ComputedStyle::create(); }

- NGPhysicalFragment* RunBlockLayoutAlgorithm(const NGConstraintSpace* space,

+ NGPhysicalFragment* RunBlockLayoutAlgorithm(NGConstraintSpace* space,

ikilpatrick 2016/09/29 00:18:11 can add const back in.

Gleb Lanbin 2016/09/29 17:11:15 Done.

NGBox* first_child) {

NGBlockLayoutAlgorithm algorithm(style_, first_child);

NGPhysicalFragment* frag;

@@ -157,6 +157,7 @@ TEST_F(NGBlockLayoutAlgorithmTest, CollapsingMarginsCase1) {

auto* space =

new NGConstraintSpace(HorizontalTopBottom, LeftToRight,

NGLogicalSize(LayoutUnit(100), NGSizeIndefinite));

+ space->SetIsNewBfc(true);

NGPhysicalFragment* frag = RunBlockLayoutAlgorithm(space, div1);

EXPECT_EQ(NGMarginStrut({LayoutUnit(kDiv1MarginTop)}), frag->MarginStrut());