Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 236813004: Deprecate HTMLHtmlElement.manifest (Closed)

Created:
6 years, 8 months ago by philipj_slow
Modified:
6 years, 8 months ago
Reviewers:
eseidel
CC:
blink-reviews, adamk+blink_chromium.org, dglazkov+blink, arv+blink, Inactive, watchdog-blink-watchlist_google.com
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : update test expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M LayoutTests/fast/dom/URL-attribute-reflection-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/inspector/console/console-command-copy-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/frame/UseCounter.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/html/HTMLHtmlElement.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
philipj_slow
6 years, 8 months ago (2014-04-14 17:41:21 UTC) #1
philipj_slow
"The manifest attribute only has an effect during the early stages of document load." is ...
6 years, 8 months ago (2014-04-14 17:41:54 UTC) #2
eseidel
lgtm
6 years, 8 months ago (2014-04-14 18:02:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/236813004/20001
6 years, 8 months ago (2014-04-14 18:02:20 UTC) #4
commit-bot: I haz the power
6 years, 8 months ago (2014-04-14 18:45:46 UTC) #5
Message was sent while issue was closed.
Change committed as 171503

Powered by Google App Engine
This is Rietveld 408576698