Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Side by Side Diff: content/renderer/mojo/mojo_render_process_observer.cc

Issue 236813002: Move Mojo channel initialization closer to IPC::Channel setup (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/renderer/mojo/mojo_render_process_observer.h" 5 #include "content/renderer/mojo/mojo_render_process_observer.h"
6 6
7 #include "base/message_loop/message_loop.h" 7 #include "base/message_loop/message_loop.h"
8 #include "content/child/child_process.h" 8 #include "content/child/child_process.h"
9 #include "content/common/mojo/mojo_channel_init.h" 9 #include "content/common/mojo/mojo_channel_init.h"
10 #include "content/common/mojo/mojo_messages.h" 10 #include "content/common/mojo/mojo_messages.h"
11 #include "content/public/renderer/render_thread.h" 11 #include "content/public/renderer/render_thread.h"
12 #include "content/public/renderer/render_view.h" 12 #include "content/public/renderer/render_view.h"
13 #include "content/renderer/web_ui_mojo.h" 13 #include "content/renderer/web_ui_mojo.h"
14 14
15 namespace content { 15 namespace content {
16 16
17 MojoRenderProcessObserver::MojoRenderProcessObserver( 17 MojoRenderProcessObserver::MojoRenderProcessObserver(
18 RenderThread* render_thread) 18 RenderThread* render_thread)
19 : render_thread_(render_thread) { 19 : render_thread_(render_thread) {
20 render_thread_->AddObserver(this); 20 render_thread_->AddObserver(this);
21 } 21 }
22 22
23 bool MojoRenderProcessObserver::OnControlMessageReceived( 23 bool MojoRenderProcessObserver::OnControlMessageReceived(
24 const IPC::Message& message) { 24 const IPC::Message& message) {
25 bool handled = true; 25 bool handled = true;
26 IPC_BEGIN_MESSAGE_MAP(MojoRenderProcessObserver, message) 26 IPC_BEGIN_MESSAGE_MAP(MojoRenderProcessObserver, message)
27 IPC_MESSAGE_HANDLER(MojoMsg_ChannelCreated, OnChannelCreated) 27 IPC_MESSAGE_HANDLER(MojoMsg_Activate, OnActivate)
28 IPC_MESSAGE_UNHANDLED(handled = false) 28 IPC_MESSAGE_UNHANDLED(handled = false)
29 IPC_END_MESSAGE_MAP() 29 IPC_END_MESSAGE_MAP()
30 return handled; 30 return handled;
31 } 31 }
32 32
33 void MojoRenderProcessObserver::OnRenderProcessShutdown() { 33 void MojoRenderProcessObserver::OnRenderProcessShutdown() {
34 delete this; 34 delete this;
35 } 35 }
36 36
37 MojoRenderProcessObserver::~MojoRenderProcessObserver() { 37 MojoRenderProcessObserver::~MojoRenderProcessObserver() {
38 render_thread_->RemoveObserver(this); 38 render_thread_->RemoveObserver(this);
39 } 39 }
40 40
41 void MojoRenderProcessObserver::OnChannelCreated( 41 void MojoRenderProcessObserver::OnActivate(
42 const IPC::PlatformFileForTransit& file) { 42 const IPC::PlatformFileForTransit& file) {
43 #if defined(OS_POSIX) 43 #if defined(OS_POSIX)
44 base::PlatformFile handle = file.fd; 44 base::PlatformFile handle = file.fd;
45 #elif defined(OS_WIN) 45 #elif defined(OS_WIN)
46 base::PlatformFile handle = file; 46 base::PlatformFile handle = file;
47 #endif 47 #endif
48 DCHECK(!channel_init_.get()); 48 DCHECK(!channel_init_.get());
49 channel_init_.reset(new MojoChannelInit); 49 channel_init_.reset(new MojoChannelInit);
50 channel_init_->Init(handle, ChildProcess::current()->io_message_loop_proxy()); 50 mojo::ScopedMessagePipeHandle message_pipe =
51 if (!channel_init_->is_handle_valid()) 51 channel_init_->Init(handle,
52 return; 52 ChildProcess::current()->io_message_loop_proxy());
53 DCHECK(message_pipe.is_valid());
53 54
54 ScopedRenderProcessHostMojoHandle render_process_host_handle( 55 render_process_host_.reset(
55 RenderProcessHostMojoHandle( 56 ScopedIRenderProcessHostHandle::From(message_pipe.Pass()), this);
56 channel_init_->bootstrap_message_pipe().release().value()));
57 render_process_host_mojo_.reset(render_process_host_handle.Pass(), this);
58 } 57 }
59 58
60 void MojoRenderProcessObserver::SetWebUIHandle( 59 void MojoRenderProcessObserver::SetWebUIHandle(
61 int32 view_routing_id, 60 int32 view_routing_id,
62 mojo::ScopedMessagePipeHandle web_ui_handle) { 61 mojo::ScopedMessagePipeHandle web_ui_handle) {
63 RenderView* render_view = RenderView::FromRoutingID(view_routing_id); 62 RenderView* render_view = RenderView::FromRoutingID(view_routing_id);
64 if (!render_view) 63 if (!render_view)
65 return; 64 return;
66 WebUIMojo* web_ui_mojo = WebUIMojo::Get(render_view); 65 WebUIMojo* web_ui_mojo = WebUIMojo::Get(render_view);
67 if (!web_ui_mojo) 66 if (!web_ui_mojo)
68 return; 67 return;
69 web_ui_mojo->SetBrowserHandle(web_ui_handle.Pass()); 68 web_ui_mojo->SetBrowserHandle(web_ui_handle.Pass());
70 } 69 }
71 70
72 } // namespace content 71 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698