Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(772)

Issue 2368113003: Use Ahem font in fast/images/color-profile-background-clip-text.html (Closed)

Created:
4 years, 2 months ago by ericrk
Modified:
4 years, 2 months ago
Reviewers:
ccameron
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use Ahem font in fast/images/color-profile-background-clip-text.html We weren't pulling in the Ahem font correctly, leading to different results on each platform (as a different fallback was chosen). R=ccameron BUG=624233 Committed: https://crrev.com/030f03cb171559c460ee53021bba37186035bb7e Cr-Commit-Position: refs/heads/master@{#421699}

Patch Set 1 #

Patch Set 2 : add rebaseline for non-gpu recipe #

Patch Set 3 : actually fix the right thing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/images/color-profile-background-clip-text.html View 3 chunks +3 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 21 (10 generated)
ericrk
4 years, 2 months ago (2016-09-26 20:50:45 UTC) #1
ccameron
lgtm
4 years, 2 months ago (2016-09-27 00:03:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2368113003/1
4 years, 2 months ago (2016-09-27 18:25:03 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/300607)
4 years, 2 months ago (2016-09-27 19:13:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2368113003/1
4 years, 2 months ago (2016-09-27 19:52:49 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/303757)
4 years, 2 months ago (2016-09-27 20:35:23 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2368113003/20001
4 years, 2 months ago (2016-09-28 17:54:58 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/268750)
4 years, 2 months ago (2016-09-28 18:04:59 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2368113003/40001
4 years, 2 months ago (2016-09-28 22:55:02 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-09-29 00:55:32 UTC) #19
commit-bot: I haz the power
4 years, 2 months ago (2016-09-29 01:07:36 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/030f03cb171559c460ee53021bba37186035bb7e
Cr-Commit-Position: refs/heads/master@{#421699}

Powered by Google App Engine
This is Rietveld 408576698