build/android/pylib/cache_control.py - Issue 23681011: Android: splits cache_control and perf_control.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: build/android/pylib/cache_control.py

Issue 23681011: Android: splits cache_control and perf_control. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
	frankf 2013/09/16 18:09:23 Can we move all perf-specific modules to perf/ dir Can we move all perf-specific modules to perf/ dir? dtu 2013/09/16 18:36:59 Feel free to put them in telemetry/core/platform/a Show quoted text On 2013/09/16 18:09:23, frankf wrote: > Can we move all perf-specific modules to perf/ dir? Feel free to put them in telemetry/core/platform/android or wherever else you think fits. bulach 2013/09/16 19:51:10 good point, moved to build/android/pylib/perf rea Show quoted text On 2013/09/16 18:36:59, dtu wrote: > On 2013/09/16 18:09:23, frankf wrote: > > Can we move all perf-specific modules to perf/ dir? > > Feel free to put them in telemetry/core/platform/android or wherever else you > think fits. good point, moved to build/android/pylib/perf reason being that downstream has some dependencies to it and already depend on pylib, so I wouldn't want to make them dependent on telemetry..
	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 import android_commands

	6

	7

	8 class CacheControl(object):

	9 _DROP_CACHES = '/proc/sys/vm/drop_caches'

	10

	11 def __init__(self, adb):

	12 self._adb = adb

	13

	14 def DropRamCaches(self):

	15 """Drops the filesystem ram caches for performance testing."""

	16 self._adb.RunShellCommand('su -c sync')
	frankf 2013/09/16 18:09:23 Can we add a RunShellCommandAsRoot('sync')? It hel Can we add a RunShellCommandAsRoot('sync')? It helps SEO :) bulach 2013/09/16 19:51:10 Done. Show quoted text On 2013/09/16 18:09:23, frankf wrote: > Can we add a RunShellCommandAsRoot('sync')? > It helps SEO :) Done.
	17 self._adb.SetProtectedFileContents(CacheControl._DROP_CACHES, '3')

	18

OLD	NEW

« no previous file with comments | « no previous file | build/android/pylib/perf_control.py » ('j') | build/android/pylib/perf_control.py » ('J')