mac: Add a test for various bundle resource scenarious.

ninja/mac: Support rules running on mac_bundle_resources.

Also add a test for various bundle resource scenarious.

BUG=chromium:280718
R=mark@chromium.org

Committed: https://code.google.com/p/gyp/source/detail?r=1714

[Nico, 2013-09-04 20:55:44]

(The failing test is what's needed to squeeze pdfs in chromium's build)

[Nico, 2013-09-04 21:12:23]

Patch set 2 makes the new test pass in ninja too, ptal.

[Mark Mentovai, 2013-09-04 21:16:34]

LGTM otherwise

https://codereview.chromium.org/23681007/diff/1/test/mac/bundle-resources/cha...
File test/mac/bundle-resources/change.sh (right):

https://codereview.chromium.org/23681007/diff/1/test/mac/bundle-resources/cha...
test/mac/bundle-resources/change.sh:1: #!/usr/bin/env bash
#!/bin/bash

https://codereview.chromium.org/23681007/diff/1/test/mac/bundle-resources/cha...
test/mac/bundle-resources/change.sh:1: #!/usr/bin/env bash
It’s not clear from the diff that this will be committed with the x-bit set, but
you rely on that, so just make sure that it’s set properly in the versioning
system du jour.

https://codereview.chromium.org/23681007/diff/1/test/mac/gyptest-bundle-resou...
File test/mac/gyptest-bundle-resources.py (right):

https://codereview.chromium.org/23681007/diff/1/test/mac/gyptest-bundle-resou...
test/mac/gyptest-bundle-resources.py:1: 
Blank line.

https://codereview.chromium.org/23681007/diff/1/test/mac/gyptest-bundle-resou...
test/mac/gyptest-bundle-resources.py:32: #'ABC\n', chdir=CHDIR)
Weird place to put the #, I almost missed it there.

https://codereview.chromium.org/23681007/diff/6001/test/mac/gyptest-bundle-re...
File test/mac/gyptest-bundle-resources.py (right):

https://codereview.chromium.org/23681007/diff/6001/test/mac/gyptest-bundle-re...
test/mac/gyptest-bundle-resources.py:33:
'resource_rule.app/Contents/Resources/secret.txt', 'ABC\n', chdir=CHDIR)
Whoops, that’s irrelevant now.

[Nico, 2013-09-04 21:20:46]

Thanks!

https://codereview.chromium.org/23681007/diff/1/test/mac/bundle-resources/cha...
File test/mac/bundle-resources/change.sh (right):

https://codereview.chromium.org/23681007/diff/1/test/mac/bundle-resources/cha...
test/mac/bundle-resources/change.sh:1: #!/usr/bin/env bash
On 2013/09/04 21:16:34, Mark Mentovai wrote:
> It’s not clear from the diff that this will be committed with the x-bit set,
but
> you rely on that, so just make sure that it’s set properly in the versioning
> system du jour.

It's set.

Changed to /bin/bash, but I got a CL for changing /bin/bash to /usr/bin/env bash
elsewhere in chromium, for some BSD I think.

https://codereview.chromium.org/23681007/diff/1/test/mac/gyptest-bundle-resou...
File test/mac/gyptest-bundle-resources.py (right):

https://codereview.chromium.org/23681007/diff/1/test/mac/gyptest-bundle-resou...
test/mac/gyptest-bundle-resources.py:1: 
On 2013/09/04 21:16:34, Mark Mentovai wrote:
> Blank line.

Done.

https://codereview.chromium.org/23681007/diff/1/test/mac/gyptest-bundle-resou...
test/mac/gyptest-bundle-resources.py:32: #'ABC\n', chdir=CHDIR)
On 2013/09/04 21:16:34, Mark Mentovai wrote:
> Weird place to put the #, I almost missed it there.

Done.

https://codereview.chromium.org/23681007/diff/6001/test/mac/gyptest-bundle-re...
File test/mac/gyptest-bundle-resources.py (right):

https://codereview.chromium.org/23681007/diff/6001/test/mac/gyptest-bundle-re...
test/mac/gyptest-bundle-resources.py:33:
'resource_rule.app/Contents/Resources/secret.txt', 'ABC\n', chdir=CHDIR)
On 2013/09/04 21:16:34, Mark Mentovai wrote:
> Whoops, that’s irrelevant now.

Done.

[Nico, 2013-09-04 21:21:45]

Apparently try jobs for chmodded files don't work :-/ Landing, and watching the
tree…

[Mark Mentovai, 2013-09-04 21:22:37]

You could change the invocation in the gyp file to put 'bash' before your
script’s name.

Or change it for the try and change it back for the land. I’ve done that before.

[Nico, 2013-09-04 21:42:19]

Committed patchset #3 manually as r1714 (presubmit successful).