Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: third_party/WebKit/LayoutTests/fragmentation/repeating-thead-multiple-tables-expected.html

Issue 2368093002: Handle repeated headers when more than one table in paged context (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/fragmentation/repeating-thead-multiple-tables-expected.html
diff --git a/third_party/WebKit/LayoutTests/fragmentation/single-line-cells-repeating-thead-starts-middle-of-page.html b/third_party/WebKit/LayoutTests/fragmentation/repeating-thead-multiple-tables-expected.html
similarity index 70%
copy from third_party/WebKit/LayoutTests/fragmentation/single-line-cells-repeating-thead-starts-middle-of-page.html
copy to third_party/WebKit/LayoutTests/fragmentation/repeating-thead-multiple-tables-expected.html
index 41cc641476840dd66a3c338877df9fe079a44216..8b820b13cacf2e95ea436966ae99020c2b0ebbd9 100644
--- a/third_party/WebKit/LayoutTests/fragmentation/single-line-cells-repeating-thead-starts-middle-of-page.html
+++ b/third_party/WebKit/LayoutTests/fragmentation/repeating-thead-multiple-tables-expected.html
@@ -3,28 +3,17 @@
table {
border-collapse: collapse;
}
-td, th {
- background-color: #ddd;
- border: 1px solid black;
-}
-thead, tr {
+tr {
break-inside: avoid;
}
+.header {
+ font-weight: bold;
+}
</style>
-<p>crbug.com/24826: A table header group repeats on each page, even when the first one starts in the middle of the first page.</p>
-<div style="-webkit-columns:3; line-height: 20px; column-fill: auto; height:190px; background-color: yellow;">
- <br>
- <br>
- <br>
+<p>crbug.com/621258: Don't let repeating headers overlap on pages that contain two tables.</p>
+<div style="-webkit-columns:3; line-height: 20px; column-fill: auto; height:190px;">
<table>
- <thead>
- <tr>
- <th>Col 1</th>
- <th>Col 2</th>
- </tr>
- </thead>
- <tbody>
- <tr><td>Te</td><td>xt</td></tr>
+ <tr><td class="header" colspan=2>Col 1</td></tr>
<tr><td>Te</td><td>xt</td></tr>
<tr><td>Te</td><td>xt</td></tr>
<tr><td>Te</td><td>xt</td></tr>
@@ -32,10 +21,17 @@ thead, tr {
<tr><td>Te</td><td>xt</td></tr>
<tr><td>Te</td><td>xt</td></tr>
<tr><td>Te</td><td>xt</td></tr>
+ <tr><td class="header" colspan=2>Col 1</td></tr>
<tr><td>Te</td><td>xt</td></tr>
<tr><td>Te</td><td>xt</td></tr>
+ </table>
+ <br>
+ <br>
+ <table>
+ <tr><td class="header" colspan=2>Col 2</td></tr>
<tr><td>Te</td><td>xt</td></tr>
<tr><td>Te</td><td>xt</td></tr>
+ <tr><td class="header" colspan=2>Col 2</td></tr>
<tr><td>Te</td><td>xt</td></tr>
<tr><td>Te</td><td>xt</td></tr>
<tr><td>Te</td><td>xt</td></tr>
@@ -43,11 +39,11 @@ thead, tr {
<tr><td>Te</td><td>xt</td></tr>
<tr><td>Te</td><td>xt</td></tr>
<tr><td>Te</td><td>xt</td></tr>
+ <tr><td class="header" colspan=2>Col 2</td></tr>
<tr><td>Te</td><td>xt</td></tr>
<tr><td>Te</td><td>xt</td></tr>
<tr><td>Te</td><td>xt</td></tr>
<tr><td>Te</td><td>xt</td></tr>
- </tbody>
</table>
</div>

Powered by Google App Engine
This is Rietveld 408576698