Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2368073004: Add --packages flag when compiling dart2js snapshot (Closed)

Created:
4 years, 2 months ago by Bill Hesse
Modified:
4 years, 2 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add --packages flag when compiling dart2js snapshot BUG= R=paulberry@google.com Committed: https://github.com/dart-lang/sdk/commit/1f97819b25c593eebbea9dac535577bdbde796d8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M utils/compiler/create_snapshot.dart View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
Bill Hesse
The dart2js created in the SDK stopped working after CL https://codereview.chromium.org/2372573002 You don't know any ...
4 years, 2 months ago (2016-09-26 15:48:06 UTC) #2
Bill Hesse
4 years, 2 months ago (2016-09-26 16:33:59 UTC) #4
Bill Hesse
On 2016/09/26 16:33:59, Bill Hesse wrote: The issue on the buildbot seems to have resolved ...
4 years, 2 months ago (2016-09-26 16:39:01 UTC) #5
Paul Berry
lgtm
4 years, 2 months ago (2016-09-26 16:45:43 UTC) #6
Bill Hesse
Committed patchset #1 (id:1) manually as 1f97819b25c593eebbea9dac535577bdbde796d8 (presubmit successful).
4 years, 2 months ago (2016-09-26 16:48:33 UTC) #8
scheglov
lgtm
4 years, 2 months ago (2016-09-26 16:48:47 UTC) #9
Siggi Cherem (dart-lang)
4 years, 2 months ago (2016-09-28 19:39:30 UTC) #11
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698