Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 2368073003: Relax '*' in CSPSourceList to match the protected resource's protocol. (Closed)

Created:
4 years, 2 months ago by Mike West
Modified:
4 years, 2 months ago
Reviewers:
Torne
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Relax '*' in CSPSourceList to match the protected resource's protocol. '*' should match 'file://whatever.jpg' when loaded from 'file://document.html'. The patch in [1] tightened '*'s behavior, but missed this bit. [1]: https://codereview.chromium.org/2209113002 BUG=648508 Committed: https://crrev.com/d55f533b68355157431105281d485ef368e857a6 Cr-Commit-Position: refs/heads/master@{#421129}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -6 lines) Patch
M third_party/WebKit/Source/core/frame/csp/CSPSourceList.cpp View 1 chunk +4 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/frame/csp/CSPSourceListTest.cpp View 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (11 generated)
Mike West
Have a moment to take a look at this, torne@? It should fix the webview ...
4 years, 2 months ago (2016-09-26 14:58:41 UTC) #2
Torne
lgtm
4 years, 2 months ago (2016-09-26 15:12:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2368073003/1
4 years, 2 months ago (2016-09-26 16:11:30 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/286224)
4 years, 2 months ago (2016-09-26 17:39:54 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2368073003/1
4 years, 2 months ago (2016-09-26 18:37:16 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/286467)
4 years, 2 months ago (2016-09-26 20:17:51 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2368073003/1
4 years, 2 months ago (2016-09-27 05:49:38 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-27 06:34:40 UTC) #18
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 06:36:38 UTC) #20
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d55f533b68355157431105281d485ef368e857a6
Cr-Commit-Position: refs/heads/master@{#421129}

Powered by Google App Engine
This is Rietveld 408576698