Lint suppressions needed for Android SDK roll.

Lint suppressions needed for Android SDK roll.

This is only part of the suppressions needed for a full compile, I'm splitting them up into separate CLs to make OWNERS review easier.

BUG=623989
R=nyquist@chromium.org, jbudorick@chromium.org

Committed: https://crrev.com/22b1e2c7a0b3e832ebfcd0efecfd4fe5fbf3c209
Cr-Commit-Position: refs/heads/master@{#421034}

[ghost stip (do not use), 2016-09-23 23:54:50]

jbudorick: ptal
nyquist: OWNERS

[jbudorick, 2016-09-24 03:44:51]

lgtm

[nyquist, 2016-09-24 22:08:11]

components/sync lgtm

[ghost stip (do not use), 2016-09-26 03:58:12]

Description was changed from

==========
Lint suppressions needed for Android SDK roll.

This is only part of the suppressions needed for a full compile, I'm splitting
them up into separate CLs to make OWNERS review easier.

BUG=623989
R=nyquist@chromium.org, jbudorick@chromium.org
==========

to

==========
Lint suppressions needed for Android SDK roll.

This is only part of the suppressions needed for a full compile, I'm splitting
them up into separate CLs to make OWNERS review easier.

BUG=623989
R=nyquist@chromium.org, jbudorick@chromium.org
==========

[ghost stip (do not use), 2016-09-26 03:58:13]

stip@chromium.org changed reviewers:
+ mef@chromium.org

[ghost stip (do not use), 2016-09-26 03:58:27]

mef: ptal components/cronet OWNERS

[mef, 2016-09-26 14:57:11]

components/cronet lgtm
Out of curiosity - what is DefaultLocale warning?

[nyquist, 2016-09-26 20:44:15]

On 2016/09/26 14:57:11, mef wrote:
> components/cronet lgtm
> Out of curiosity - what is DefaultLocale warning?

In the cronet-case I believe it's for the String.format() of the log statement
where you usually want to pass in a locale.

The default locale gives you the device specific one, which can be changed over
time, so you need to be super careful if you for example use it for persistence,
etc.

Personally I think I'd just specfiy Locale.US, since the log string is in
English, and then you should be able to remove the lint suppression.

What the author does here, is to ensure that nothing changes from the currently
checked in code.


Copy-paste from http://tools.android.com/tips/lint-checks:
-------------
Summary: Implied default locale in case conversion

Priority: 6 / 10
Severity: Warning
Category: Correctness

Calling String#toLowerCase() or #toUpperCase() without specifying an explicit
locale is a common source of bugs. The reason for that is that those methods
will use the current locale on the user's device, and even though the code
appears to work correctly when you are developing the app, it will fail in
some locales. For example, in the Turkish locale, the uppercase replacement
for i is not I.

If you want the methods to just perform ASCII replacement, for example to
convert an enum name, call String#toUpperCase(Locale.US) instead. If you
really want to use the current locale, call
String#toUpperCase(Locale.getDefault()) instead.

More information: 
http://developer.android.com/reference/java/util/Locale.html#default_locale

[ghost stip (do not use), 2016-09-26 21:50:25]

The CQ bit was checked by stip@chromium.org

[commit-bot: I haz the power, 2016-09-26 21:51:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-26 23:18:44]

Description was changed from

==========
Lint suppressions needed for Android SDK roll.

This is only part of the suppressions needed for a full compile, I'm splitting
them up into separate CLs to make OWNERS review easier.

BUG=623989
R=nyquist@chromium.org, jbudorick@chromium.org
==========

to

==========
Lint suppressions needed for Android SDK roll.

This is only part of the suppressions needed for a full compile, I'm splitting
them up into separate CLs to make OWNERS review easier.

BUG=623989
R=nyquist@chromium.org, jbudorick@chromium.org
==========

[commit-bot: I haz the power, 2016-09-26 23:18:45]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-26 23:20:53]

Description was changed from

==========
Lint suppressions needed for Android SDK roll.

This is only part of the suppressions needed for a full compile, I'm splitting
them up into separate CLs to make OWNERS review easier.

BUG=623989
R=nyquist@chromium.org, jbudorick@chromium.org
==========

to

==========
Lint suppressions needed for Android SDK roll.

This is only part of the suppressions needed for a full compile, I'm splitting
them up into separate CLs to make OWNERS review easier.

BUG=623989
R=nyquist@chromium.org, jbudorick@chromium.org

Committed: https://crrev.com/22b1e2c7a0b3e832ebfcd0efecfd4fe5fbf3c209
Cr-Commit-Position: refs/heads/master@{#421034}
==========

[commit-bot: I haz the power, 2016-09-26 23:20:54]

Patchset 1 (id:??) landed as
https://crrev.com/22b1e2c7a0b3e832ebfcd0efecfd4fe5fbf3c209
Cr-Commit-Position: refs/heads/master@{#421034}