Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(560)

Unified Diff: net/spdy/spdy_headers_handler_interface.h

Issue 2367973002: Log compressed size of HTTP/2 requests. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/spdy/spdy_headers_block_parser_test.cc ('k') | net/spdy/spdy_no_op_visitor.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/spdy_headers_handler_interface.h
diff --git a/net/spdy/spdy_headers_handler_interface.h b/net/spdy/spdy_headers_handler_interface.h
index 2c48abfe94120ad9dde1aae9cf4bc8c875b83be0..e4652ddef8be2afaf89c1f2118ffaadee34d26a5 100644
--- a/net/spdy/spdy_headers_handler_interface.h
+++ b/net/spdy/spdy_headers_handler_interface.h
@@ -27,10 +27,18 @@ class NET_EXPORT_PRIVATE SpdyHeadersHandlerInterface {
// values for a given key will be emitted as multiple calls to OnHeader.
virtual void OnHeader(base::StringPiece key, base::StringPiece value) = 0;
+ // TODO(yasong): deprecate this method with
+ // --gfe2_reloadable_flag_log_compressed_size.
// A callback method which notifies when the parser finishes handling a
// header block (i.e. the containing frame has the END_HEADERS flag set).
// Also indicates the total number of bytes in this block.
virtual void OnHeaderBlockEnd(size_t uncompressed_header_bytes) = 0;
+
+ // A callback method which notifies when the parser finishes handling a
+ // header block (i.e. the containing frame has the END_HEADERS flag set).
+ // Also indicates the total number of bytes in this block.
+ virtual void OnHeaderBlockEnd(size_t uncompressed_header_bytes,
+ size_t compressed_header_bytes) = 0;
};
} // namespace net
« no previous file with comments | « net/spdy/spdy_headers_block_parser_test.cc ('k') | net/spdy/spdy_no_op_visitor.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698