Implement OnMemoryStateChange for Various CC Classes

Implement OnMemoryStateChange for Various CC Classes

Adds SUSPENDED handling for:
cc::ResourcePool
cc::GpuImageDecodeController
cc::StagingBufferPool

Additionally adds THROTTLED handling for:
cc::GpuImageDecodeController

Additional THROTTLED handling will be added in a follow-up CL.

R=vmpstr
BUG=635419
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/0cbb20ce38c9fc1a7b57526a5c16b1d325ae3e22
Cr-Commit-Position: refs/heads/master@{#421018}

[ericrk, 2016-09-23 20:14:53]

Description was changed from

==========
Implement OnMemoryStateChange for Various CC Classes

Adds SUSPENDED handling for:
cc::ResourcePool
cc::GpuImageDecodeController
cc::StagingBufferPool

Additionally adds THROTTLED handling for:
cc::GpuImageDecodeController

Additional THROTTLED handling will be added in a follow-up CL.

R=vmpstr
BUG=635419
==========

to

==========
Implement OnMemoryStateChange for Various CC Classes

Adds SUSPENDED handling for:
cc::ResourcePool
cc::GpuImageDecodeController
cc::StagingBufferPool

Additionally adds THROTTLED handling for:
cc::GpuImageDecodeController

Additional THROTTLED handling will be added in a follow-up CL.

R=vmpstr
BUG=635419
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[vmpstr, 2016-09-23 20:59:11]

https://codereview.chromium.org/2367953002/diff/1/cc/resources/resource_pool.cc
File cc/resources/resource_pool.cc (right):

https://codereview.chromium.org/2367953002/diff/1/cc/resources/resource_pool....
cc/resources/resource_pool.cc:475: DCHECK_EQ(0, unused_resources_.size());
Are we guaranteed that we receive this signal after we get backgrounded? I'm
curious about order of events here.

https://codereview.chromium.org/2367953002/diff/1/cc/tiles/software_image_dec...
File cc/tiles/software_image_decode_controller.cc (right):

https://codereview.chromium.org/2367953002/diff/1/cc/tiles/software_image_dec...
cc/tiles/software_image_decode_controller.cc:1097: // todo(tasak): free this
component's caches as much as possible before
<_<

[ericrk, 2016-09-23 21:22:46]

Patchset #3 (id:40001) has been deleted

[ericrk, 2016-09-23 21:24:12]

Patchset #3 (id:60001) has been deleted

[ericrk, 2016-09-23 21:26:07]

Patchset #3 (id:80001) has been deleted

[ericrk, 2016-09-23 21:26:15]

https://codereview.chromium.org/2367953002/diff/1/cc/resources/resource_pool.cc
File cc/resources/resource_pool.cc (right):

https://codereview.chromium.org/2367953002/diff/1/cc/resources/resource_pool....
cc/resources/resource_pool.cc:475: DCHECK_EQ(0, unused_resources_.size());
On 2016/09/23 20:59:10, vmpstr wrote:
> Are we guaranteed that we receive this signal after we get backgrounded? I'm
> curious about order of events here.

My understanding was that we are only suspended while invisible. That said, it
seems fragile to rely on this ordering. Re-structed so that we can handle any
order of calls.

https://codereview.chromium.org/2367953002/diff/1/cc/tiles/software_image_dec...
File cc/tiles/software_image_decode_controller.cc (right):

https://codereview.chromium.org/2367953002/diff/1/cc/tiles/software_image_dec...
cc/tiles/software_image_decode_controller.cc:1097: // todo(tasak): free this
component's caches as much as possible before
On 2016/09/23 20:59:10, vmpstr wrote:
> <_<

Acknowledged.

[vmpstr, 2016-09-23 21:49:07]

lgtm

[ericrk, 2016-09-24 02:04:16]

ericrk@chromium.org changed reviewers:
+ haraken@chromium.org

[ericrk, 2016-09-24 02:04:16]

haraken@ - here's the CL to implement SUSPENDED (and some THROTTLED) .

[haraken, 2016-09-25 22:42:18]

LGTM, thanks!

[ericrk, 2016-09-26 20:41:42]

The CQ bit was checked by ericrk@chromium.org

[commit-bot: I haz the power, 2016-09-26 20:42:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-26 22:16:42]

Committed patchset #3 (id:100001)

[commit-bot: I haz the power, 2016-09-26 22:19:08]

Description was changed from

==========
Implement OnMemoryStateChange for Various CC Classes

Adds SUSPENDED handling for:
cc::ResourcePool
cc::GpuImageDecodeController
cc::StagingBufferPool

Additionally adds THROTTLED handling for:
cc::GpuImageDecodeController

Additional THROTTLED handling will be added in a follow-up CL.

R=vmpstr
BUG=635419
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Implement OnMemoryStateChange for Various CC Classes

Adds SUSPENDED handling for:
cc::ResourcePool
cc::GpuImageDecodeController
cc::StagingBufferPool

Additionally adds THROTTLED handling for:
cc::GpuImageDecodeController

Additional THROTTLED handling will be added in a follow-up CL.

R=vmpstr
BUG=635419
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/0cbb20ce38c9fc1a7b57526a5c16b1d325ae3e22
Cr-Commit-Position: refs/heads/master@{#421018}
==========

[commit-bot: I haz the power, 2016-09-26 22:19:09]

Patchset 3 (id:??) landed as
https://crrev.com/0cbb20ce38c9fc1a7b57526a5c16b1d325ae3e22
Cr-Commit-Position: refs/heads/master@{#421018}