Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Unified Diff: ui/base/BUILD.gn

Issue 2367923002: Fail to build with unbound Info.plist substitutions instead of silently dropping them. (Closed)
Patch Set: Rebase to pick up crrev/c/555912 Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/config/mac/plist_util.py ('k') | ui/base/test/framework-Info.plist » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/base/BUILD.gn
diff --git a/ui/base/BUILD.gn b/ui/base/BUILD.gn
index 710731ee9d7f6e38fae07271e2a4f99e59b474d9..4441ecbe140f55b69e6cbc82e53a9ab12b2b78ab 100644
--- a/ui/base/BUILD.gn
+++ b/ui/base/BUILD.gn
@@ -6,6 +6,7 @@ import("//build/buildflag_header.gni")
import("//build/config/compiler/compiler.gni")
import("//build/config/sanitizers/sanitizers.gni")
import("//build/config/ui.gni")
+import("//build/util/branding.gni")
import("//testing/test.gni")
import("//ui/base/ui_features.gni")
import("//ui/ozone/ozone.gni")
@@ -1014,6 +1015,7 @@ if (is_mac) {
"//ui/resources:ui_test_pak_bundle_data",
]
info_plist = "test/framework-Info.plist"
+ extra_substitutions = [ "CHROMIUM_BUNDLE_ID=$chrome_mac_bundle_id" ]
output_name = "ui_unittests Framework"
}
}
« no previous file with comments | « build/config/mac/plist_util.py ('k') | ui/base/test/framework-Info.plist » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698