build/config/mac/BuildInfo.plist - Issue 2367923002: Fail to build with unbound Info.plist substitutions instead of silently dropping them.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/mac/BuildInfo.plist

Issue 2367923002: Fail to build with unbound Info.plist substitutions instead of silently dropping them. (Closed)

Patch Set: Fix a SubstitutionError Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/config/mac/BuildInfo.plist

diff --git a/build/config/mac/BuildInfo.plist b/build/config/mac/BuildInfo.plist

index b0856e3591d2df61feb42cb13caecc076d8018a0..d32bf2ea7f41274fc3ed799cedcc68f35a3f97e0 100644

--- a/build/config/mac/BuildInfo.plist

+++ b/build/config/mac/BuildInfo.plist

@@ -14,13 +14,5 @@

<string>${XCODE_VERSION}</string>

<key>DTXcodeBuild</key>

<string>${XCODE_BUILD}</string>

- <key>CFBundleShortVersionString</key>

- <string>${VERSION}</string>

- <key>CFBundleVersion</key>

- <string>${VERSION_BUILD}</string>

- <key>CFBundleIdentifier</key>

- <string>org.chromium.${PRODUCT_NAME:rfc1034identifier}</string>

- <key>SCM_REVISION</key>

- <string>${COMMIT_HASH}</string>

Nico 2017/06/26 14:47:18 From the Cl description, this removal here is beha

Sidney San Martín 2017/06/26 17:40:03 Yes, as far as I can tell all of these keys are ei

</dict>

</plist>

« no previous file with comments | « no previous file | build/config/mac/plist_util.py » ('j') | no next file with comments »