build/config/mac/BuildInfo.plist - Issue 2367923002: Fail to build with unbound Info.plist substitutions instead of silently dropping them.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: build/config/mac/BuildInfo.plist

Issue 2367923002: Fail to build with unbound Info.plist substitutions instead of silently dropping them. (Closed)

Patch Set: Rebase to pick up crrev/c/555912 Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 <?xml version="1.0" encoding="UTF-8"?>	1 <?xml version="1.0" encoding="UTF-8"?>

2 <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/ PropertyList-1.0.dtd">	2 <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/ PropertyList-1.0.dtd">

3 <plist version="1.0">	3 <plist version="1.0">

4 <dict>	4 <dict>

5 <key>BuildMachineOSBuild</key>	5 <key>BuildMachineOSBuild</key>

6 <string>${BUILD_MACHINE_OS_BUILD}</string>	6 <string>${BUILD_MACHINE_OS_BUILD}</string>

7 <key>DTCompiler</key>	7 <key>DTCompiler</key>

8 <string>${GCC_VERSION}</string>	8 <string>${GCC_VERSION}</string>

9 <key>DTSDKBuild</key>	9 <key>DTSDKBuild</key>

10 <string>${MAC_SDK_BUILD}</string>	10 <string>${MAC_SDK_BUILD}</string>

11 <key>DTSDKName</key>	11 <key>DTSDKName</key>

12 <string>${MAC_SDK_NAME}</string>	12 <string>${MAC_SDK_NAME}</string>

13 <key>DTXcode</key>	13 <key>DTXcode</key>

14 <string>${XCODE_VERSION}</string>	14 <string>${XCODE_VERSION}</string>

15 <key>DTXcodeBuild</key>	15 <key>DTXcodeBuild</key>

16 <string>${XCODE_BUILD}</string>	16 <string>${XCODE_BUILD}</string>

17 <key>CFBundleShortVersionString</key>

18 <string>${VERSION}</string>

19 <key>CFBundleVersion</key>

20 <string>${VERSION_BUILD}</string>

21 <key>CFBundleIdentifier</key>

22 <string>org.chromium.${PRODUCT_NAME:rfc1034identifier}</string>

23 <key>SCM_REVISION</key>

24 <string>${COMMIT_HASH}</string>

25 </dict>	17 </dict>

26 </plist>	18 </plist>

OLD	NEW

« no previous file with comments | « no previous file | build/config/mac/plist_util.py » ('j') | no next file with comments »