Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Side by Side Diff: extensions/shell/app/app-Info.plist

Issue 2367923002: Fail to build with unbound Info.plist substitutions instead of silently dropping them. (Closed)
Patch Set: Hard code one more instance of LSMinimumSystemVersion Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/config/mac/plist_util.py ('k') | extensions/shell/app/helper-Info.plist » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <?xml version="1.0" encoding="UTF-8"?> 1 <?xml version="1.0" encoding="UTF-8"?>
2 <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/ PropertyList-1.0.dtd"> 2 <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/ PropertyList-1.0.dtd">
3 <plist version="1.0"> 3 <plist version="1.0">
4 <dict> 4 <dict>
5 <key>CFBundleDevelopmentRegion</key> 5 <key>CFBundleDevelopmentRegion</key>
6 <string>en</string> 6 <string>en</string>
7 <key>CFBundleDisplayName</key> 7 <key>CFBundleDisplayName</key>
8 <string>${EXECUTABLE_NAME}</string> 8 <string>${EXECUTABLE_NAME}</string>
9 <key>CFBundleExecutable</key> 9 <key>CFBundleExecutable</key>
10 <string>${EXECUTABLE_NAME}</string> 10 <string>${EXECUTABLE_NAME}</string>
11 <key>CFBundleIconFile</key> 11 <key>CFBundleIconFile</key>
12 <string>app.icns</string> 12 <string>app.icns</string>
13 <key>CFBundleIdentifier</key> 13 <key>CFBundleIdentifier</key>
14 <string>org.chromium.AppShell</string> 14 <string>org.chromium.AppShell</string>
15 <key>CFBundleInfoDictionaryVersion</key> 15 <key>CFBundleInfoDictionaryVersion</key>
16 <string>6.0</string> 16 <string>6.0</string>
17 <key>CFBundleName</key> 17 <key>CFBundleName</key>
18 <string>${PRODUCT_NAME}</string> 18 <string>${PRODUCT_NAME}</string>
19 <key>CFBundlePackageType</key> 19 <key>CFBundlePackageType</key>
20 <string>APPL</string> 20 <string>APPL</string>
21 <key>CFBundleVersion</key> 21 <key>CFBundleVersion</key>
22 <string>1.0</string> 22 <string>1.0</string>
23 <key>NSMainNibFile</key> 23 <key>NSMainNibFile</key>
24 <string>MainMenu</string> 24 <string>MainMenu</string>
25 <key>NSPrincipalClass</key> 25 <key>NSPrincipalClass</key>
26 <string>NSApplication</string> 26 <string>NSApplication</string>
27 <key>LSMinimumSystemVersion</key> 27 <key>LSMinimumSystemVersion</key>
28 » <string>${MACOSX_DEPLOYMENT_TARGET}.0</string> 28 » <string>10.9.0</string>
sdefresne 2017/06/27 08:26:25 I don't like hardcoding the value here. It is avai
Sidney San Martín 2017/06/27 19:45:50 Done. I just remembered why it was like this in th
29 <key>LSFileQuarantineEnabled</key> 29 <key>LSFileQuarantineEnabled</key>
30 <true/> 30 <true/>
31 <key>NSSupportsAutomaticGraphicsSwitching</key> 31 <key>NSSupportsAutomaticGraphicsSwitching</key>
32 <true/> 32 <true/>
33 </dict> 33 </dict>
34 </plist> 34 </plist>
OLDNEW
« no previous file with comments | « build/config/mac/plist_util.py ('k') | extensions/shell/app/helper-Info.plist » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698