Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Side by Side Diff: ui/base/BUILD.gn

Issue 2367923002: Fail to build with unbound Info.plist substitutions instead of silently dropping them. (Closed)
Patch Set: Fix a SubstitutionError Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/buildflag_header.gni") 5 import("//build/buildflag_header.gni")
6 import("//build/config/compiler/compiler.gni") 6 import("//build/config/compiler/compiler.gni")
7 import("//build/config/sanitizers/sanitizers.gni") 7 import("//build/config/sanitizers/sanitizers.gni")
8 import("//build/config/ui.gni") 8 import("//build/config/ui.gni")
9 import("//build/util/branding.gni")
9 import("//testing/test.gni") 10 import("//testing/test.gni")
10 import("//ui/base/ui_features.gni") 11 import("//ui/base/ui_features.gni")
11 import("//ui/ozone/ozone.gni") 12 import("//ui/ozone/ozone.gni")
12 13
13 if (is_android) { 14 if (is_android) {
14 import("//build/config/android/config.gni") 15 import("//build/config/android/config.gni")
15 import("//build/config/android/rules.gni") 16 import("//build/config/android/rules.gni")
16 } else if (is_mac) { 17 } else if (is_mac) {
17 import("//build/config/mac/rules.gni") 18 import("//build/config/mac/rules.gni")
18 } 19 }
(...skipping 987 matching lines...) Expand 10 before | Expand all | Expand 10 after
1006 } 1007 }
1007 } 1008 }
1008 1009
1009 if (is_mac) { 1010 if (is_mac) {
1010 mac_framework_bundle("ui_unittests_framework") { 1011 mac_framework_bundle("ui_unittests_framework") {
1011 testonly = true 1012 testonly = true
1012 deps = [ 1013 deps = [
1013 "//ui/resources:ui_test_pak_bundle_data", 1014 "//ui/resources:ui_test_pak_bundle_data",
1014 ] 1015 ]
1015 info_plist = "test/framework-Info.plist" 1016 info_plist = "test/framework-Info.plist"
1017 extra_substitutions = [ "CHROMIUM_BUNDLE_ID=$chrome_mac_bundle_id" ]
1016 output_name = "ui_unittests Framework" 1018 output_name = "ui_unittests Framework"
1017 } 1019 }
1018 } 1020 }
1019 1021
1020 if (is_win) { 1022 if (is_win) {
1021 # This source set is used by both //chrome/browser and 1023 # This source set is used by both //chrome/browser and
1022 # //chrome/installer/setup. It must have minimal dependencies for the latter 1024 # //chrome/installer/setup. It must have minimal dependencies for the latter
1023 # (e.g., no skia). 1025 # (e.g., no skia).
1024 source_set("fullscreen_win") { 1026 source_set("fullscreen_win") {
1025 sources = [ 1027 sources = [
1026 "fullscreen_win.cc", 1028 "fullscreen_win.cc",
1027 "fullscreen_win.h", 1029 "fullscreen_win.h",
1028 ] 1030 ]
1029 } 1031 }
1030 } 1032 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698