Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1071)

Unified Diff: content/renderer/browser_plugin/browser_plugin_browsertest.cc

Issue 23679004: Remove more calls to HandleScope default ctor. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/browser_plugin/browser_plugin_browsertest.cc
diff --git a/content/renderer/browser_plugin/browser_plugin_browsertest.cc b/content/renderer/browser_plugin/browser_plugin_browsertest.cc
index 693752c618a9be543508275c936d72d9f85a76f4..d12b45bdfc266f2dd64774557ec43f7cf9968175 100644
--- a/content/renderer/browser_plugin/browser_plugin_browsertest.cc
+++ b/content/renderer/browser_plugin/browser_plugin_browsertest.cc
@@ -112,7 +112,7 @@ void BrowserPluginTest::TearDown() {
std::string BrowserPluginTest::ExecuteScriptAndReturnString(
const std::string& script) {
- v8::HandleScope handle_scope;
+ v8::HandleScope handle_scope(v8::Isolate::GetCurrent());
v8::Handle<v8::Value> value = GetMainFrame()->executeScriptAndReturnValue(
WebKit::WebScriptSource(WebKit::WebString::fromUTF8(script.c_str())));
if (value.IsEmpty() || !value->IsString())
@@ -127,7 +127,7 @@ std::string BrowserPluginTest::ExecuteScriptAndReturnString(
int BrowserPluginTest::ExecuteScriptAndReturnInt(
const std::string& script) {
- v8::HandleScope handle_scope;
+ v8::HandleScope handle_scope(v8::Isolate::GetCurrent());
v8::Handle<v8::Value> value = GetMainFrame()->executeScriptAndReturnValue(
WebKit::WebScriptSource(WebKit::WebString::fromUTF8(script.c_str())));
if (value.IsEmpty() || !value->IsInt32())
@@ -140,7 +140,7 @@ int BrowserPluginTest::ExecuteScriptAndReturnInt(
// of the script is stored in |result|
bool BrowserPluginTest::ExecuteScriptAndReturnBool(
const std::string& script, bool* result) {
- v8::HandleScope handle_scope;
+ v8::HandleScope handle_scope(v8::Isolate::GetCurrent());
v8::Handle<v8::Value> value = GetMainFrame()->executeScriptAndReturnValue(
WebKit::WebScriptSource(WebKit::WebString::fromUTF8(script.c_str())));
if (value.IsEmpty() || !value->IsBoolean())
« chrome/renderer/extensions/chrome_v8_context.h ('K') | « chrome/test/base/v8_unit_test.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698