chrome/test/base/module_system_test.cc - Issue 23679004: Remove more calls to HandleScope default ctor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/base/module_system_test.cc

Issue 23679004: Remove more calls to HandleScope default ctor. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/base/module_system_test.cc

diff --git a/chrome/test/base/module_system_test.cc b/chrome/test/base/module_system_test.cc

index d9629a73ee1fe5e4550cad2818ad6870222342c6..f4aa6455edb70f9ab8b13a3d54cc5e74b9719aea 100644

--- a/chrome/test/base/module_system_test.cc

+++ b/chrome/test/base/module_system_test.cc

@@ -188,7 +188,7 @@ void ModuleSystemTest::ExpectNoAssertionsMade() {

}

v8::Handle<v8::Object> ModuleSystemTest::CreateGlobal(const std::string& name) {

- v8::HandleScope handle_scope;

+ v8::HandleScope handle_scope(v8::Isolate::GetCurrent());

v8::Handle<v8::Object> object = v8::Object::New();

v8::Context::GetCurrent()->Global()->Set(v8::String::New(name.c_str()),

object);