Clean up AutomationPredicate

Clean up AutomationPredicate

- widen what's a combobox
- define form fields in terms of other predicates (e.g. edit text, which picks up on content editables)
- add region as landmark
- remove some roles e.g. date/date time from form fields (we want to jump to their descendant controls).

BUG=647466, 623341
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/e22e1b6c0228978b6f3cb4bd5f1c52c53cf35af0
Cr-Commit-Position: refs/heads/master@{#422127}

[David Tseng, 2016-09-23 16:55:53]

Description was changed from

==========
Clean up AutomationPredicate
==========

to

==========
Clean up AutomationPredicate
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2016-09-23 17:25:44]

Patchset #2 (id:20001) has been deleted

[David Tseng, 2016-09-23 17:25:52]

Patchset #1 (id:1) has been deleted

[David Tseng, 2016-09-23 17:31:37]

Description was changed from

==========
Clean up AutomationPredicate
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Clean up AutomationPredicate

- widen what's a combobox
- define form fields in terms of other predicates (e.g. edit text, which picks
up on content editables)
- add group and region as landmarks
- remove some roles e.g. date/date time from form fields (we want to jump to
their descendant controls).

BUG=647466
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2016-09-23 17:31:38]

dtseng@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[dmazzoni, 2016-09-23 17:52:57]

https://codereview.chromium.org/2367883002/diff/40001/chrome/browser/resource...
File
chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_predicate.js
(right):

https://codereview.chromium.org/2367883002/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_predicate.js:41:
AutomationPredicate.roles_ = function(roles) {
I think it's a little surprising to have a function
called roles_ that can take predicates too. I don't want
to hurt the nice brevity that this achieves, but it might
be nice to do it in a way that's a bit more explicit.

How about this idea:

AutomationPredicate.roles_ matches one role or an array of roles (that doesn't
seem unclear to me)

AutomationPredicate.anyPredicate_ matches if any of the predicates match

Then you could write formField like this:

AutomationPredicate.formField = AutomationPredicate.anyPredicate_(
    AutomationPredicate.button,
    AutomationPredicate.comboBox,
    AutomationPredicate.editText,
    AutomationPredicate.roles_(
        [Role.checkBox,
         Role.listBox,
         Role.slider,
         Role.tab,
         Role.tree]));

I think that'd be just as concise but a little easier to read.

https://codereview.chromium.org/2367883002/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_predicate.js:279:
(node.role == Role.client ||
This looks like a great opportunity to make it more concise
by using AutomationPredicate.roles_().

[David Tseng, 2016-09-23 19:10:22]

PTAL. Added AutomationPredicate.match which takes a object dict; can extend
this as we go/as needed.

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[David Tseng, 2016-09-23 19:19:27]

Description was changed from

==========
Clean up AutomationPredicate

- widen what's a combobox
- define form fields in terms of other predicates (e.g. edit text, which picks
up on content editables)
- add group and region as landmarks
- remove some roles e.g. date/date time from form fields (we want to jump to
their descendant controls).

BUG=647466
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Clean up AutomationPredicate

- widen what's a combobox
- define form fields in terms of other predicates (e.g. edit text, which picks
up on content editables)
- add group and region as landmarks
- remove some roles e.g. date/date time from form fields (we want to jump to
their descendant controls).

BUG=647466,623341
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2016-09-23 19:23:25]

Description was changed from

==========
Clean up AutomationPredicate

- widen what's a combobox
- define form fields in terms of other predicates (e.g. edit text, which picks
up on content editables)
- add group and region as landmarks
- remove some roles e.g. date/date time from form fields (we want to jump to
their descendant controls).

BUG=647466,623341
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Clean up AutomationPredicate

- widen what's a combobox
- define form fields in terms of other predicates (e.g. edit text, which picks
up on content editables)
- add region as landmark
- remove some roles e.g. date/date time from form fields (we want to jump to
their descendant controls).

BUG=647466,623341
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2016-09-23 19:23:57]

The CQ bit was checked by dtseng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-23 19:24:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 20:57:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 20:57:28]

Dry run: This issue passed the CQ dry run.

[dmazzoni, 2016-09-26 15:42:08]

lgtm

[David Tseng, 2016-09-30 15:05:39]

The CQ bit was checked by dtseng@chromium.org

[commit-bot: I haz the power, 2016-09-30 15:05:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-30 16:26:53]

Description was changed from

==========
Clean up AutomationPredicate

- widen what's a combobox
- define form fields in terms of other predicates (e.g. edit text, which picks
up on content editables)
- add region as landmark
- remove some roles e.g. date/date time from form fields (we want to jump to
their descendant controls).

BUG=647466,623341
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Clean up AutomationPredicate

- widen what's a combobox
- define form fields in terms of other predicates (e.g. edit text, which picks
up on content editables)
- add region as landmark
- remove some roles e.g. date/date time from form fields (we want to jump to
their descendant controls).

BUG=647466,623341
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-09-30 16:26:54]

Committed patchset #4 (id:90001)

[commit-bot: I haz the power, 2016-09-30 16:28:54]

Description was changed from

==========
Clean up AutomationPredicate

- widen what's a combobox
- define form fields in terms of other predicates (e.g. edit text, which picks
up on content editables)
- add region as landmark
- remove some roles e.g. date/date time from form fields (we want to jump to
their descendant controls).

BUG=647466,623341
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Clean up AutomationPredicate

- widen what's a combobox
- define form fields in terms of other predicates (e.g. edit text, which picks
up on content editables)
- add region as landmark
- remove some roles e.g. date/date time from form fields (we want to jump to
their descendant controls).

BUG=647466,623341
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/e22e1b6c0228978b6f3cb4bd5f1c52c53cf35af0
Cr-Commit-Position: refs/heads/master@{#422127}
==========

[commit-bot: I haz the power, 2016-09-30 16:28:56]

Patchset 4 (id:??) landed as
https://crrev.com/e22e1b6c0228978b6f3cb4bd5f1c52c53cf35af0
Cr-Commit-Position: refs/heads/master@{#422127}