Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Issue 236783002: Pass NewScriptState to idbAnyToScriptValue() and idbKeyToScriptValue() (Closed)

Created:
6 years, 8 months ago by haraken
Modified:
6 years, 8 months ago
CC:
blink-reviews, Nils Barth (inactive), jsbell+idb_chromium.org, arv+blink, jsbell+bindings_chromium.org, alecflett, sof, kouhei+bindings_chromium.org, ericu+idb_chromium.org, abarth-chromium, marja+watch_chromium.org, dgrogan, adamk+blink_chromium.org, cmumford, haraken, Nate Chapin, Inactive
Visibility:
Public.

Description

Pass NewScriptState to idbAnyToScriptValue() and idbKeyToScriptValue() - This CL is one of incremental steps to remove DOMRequestState from IDB code base. - The essence of this CL is to remove DOMRequestState from idbAnyToScriptValue() and idbKeyToScriptValue(). For that goal, this CL passes NewScriptState around in a bunch of places. - This CL implements [CallWith=NewScriptState] for DOM attributes. - This CL caches NewScriptState onto ExecutableWithDatabase objects, IndexPopulator and OpenDatabaseCallback. BUG=357144 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171447

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+206 lines, -131 lines) Patch
M Source/bindings/scripts/v8_attributes.py View 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/templates/attributes.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/bindings/tests/idls/TestObject.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/bindings/tests/results/V8TestObject.cpp View 2 chunks +64 lines, -0 lines 0 comments Download
M Source/bindings/v8/DOMRequestState.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/v8/IDBBindingUtilities.h View 2 chunks +3 lines, -2 lines 0 comments Download
M Source/bindings/v8/IDBBindingUtilities.cpp View 2 chunks +7 lines, -11 lines 0 comments Download
M Source/bindings/v8/IDBBindingUtilitiesTest.cpp View 2 chunks +20 lines, -18 lines 0 comments Download
M Source/modules/indexeddb/IDBCursor.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/modules/indexeddb/IDBCursor.cpp View 2 chunks +9 lines, -12 lines 0 comments Download
M Source/modules/indexeddb/IDBCursor.idl View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/modules/indexeddb/IDBCursorWithValue.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/indexeddb/IDBDatabase.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/indexeddb/IDBDatabase.cpp View 1 chunk +3 lines, -4 lines 0 comments Download
M Source/modules/indexeddb/IDBDatabase.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/indexeddb/IDBIndex.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/indexeddb/IDBIndex.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M Source/modules/indexeddb/IDBIndex.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/indexeddb/IDBKeyRange.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/indexeddb/IDBKeyRange.cpp View 1 chunk +4 lines, -6 lines 0 comments Download
M Source/modules/indexeddb/IDBKeyRange.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/indexeddb/IDBObjectStore.h View 3 chunks +11 lines, -5 lines 0 comments Download
M Source/modules/indexeddb/IDBObjectStore.cpp View 8 chunks +13 lines, -13 lines 0 comments Download
M Source/modules/indexeddb/IDBObjectStore.idl View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/indexeddb/IDBRequest.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/indexeddb/IDBRequest.cpp View 3 chunks +4 lines, -5 lines 0 comments Download
M Source/modules/indexeddb/IDBRequest.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/indexeddb/InspectorIndexedDBAgent.cpp View 14 chunks +36 lines, -29 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
haraken
PTAL
6 years, 8 months ago (2014-04-14 07:15:52 UTC) #1
dcarney
lgtm
6 years, 8 months ago (2014-04-14 07:51:59 UTC) #2
haraken
The CQ bit was checked by haraken@chromium.org
6 years, 8 months ago (2014-04-14 07:52:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/236783002/1
6 years, 8 months ago (2014-04-14 07:52:31 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-14 08:42:42 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 8 months ago (2014-04-14 08:42:43 UTC) #6
haraken
The CQ bit was checked by haraken@chromium.org
6 years, 8 months ago (2014-04-14 08:44:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/236783002/1
6 years, 8 months ago (2014-04-14 08:44:44 UTC) #8
commit-bot: I haz the power
6 years, 8 months ago (2014-04-14 09:15:52 UTC) #9
Message was sent while issue was closed.
Change committed as 171447

Powered by Google App Engine
This is Rietveld 408576698