Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(707)

Unified Diff: samples/samples.status

Issue 23678009: fixed TodoMVC tests to include deploying to JS (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: samples/samples.status
diff --git a/samples/samples.status b/samples/samples.status
index 40b9dfcc14d0a0bc46cca52a6818e752d5affec6..e18f9e36b2cb913872b1812f06d9e51f5fcd2056 100644
--- a/samples/samples.status
+++ b/samples/samples.status
@@ -20,6 +20,9 @@ swarm/test/swarm_test: Pass, Fail # Issue 3977
[ $runtime == chrome || $runtime == ff || $runtime == safari ]
dartcombat/test/dartcombat_test: Skip # passes locally but timeout on bot?
+[ $runtime == safari || $runtime == opera || $runtime == ff || $runtime == ie9 || $runtime == ie10 ]
+third_party/todomvc: Pass, Fail # issue 12865
Jennifer Messerly 2013/08/30 23:01:10 right now TodoMVC seems broken on Firefox, but it
Siggi Cherem (dart-lang) 2013/08/30 23:22:13 not sure what is the best status here (Pass, Fail)
Jennifer Messerly 2013/09/04 04:36:40 It looks like these are actually passing now. I wa
+
[ $runtime == ie9 ]
swarm/test/swarm_ui_lib/layout/layout_test: Fail # http://dartbug.com/5132
@@ -40,11 +43,10 @@ spirodraw: Skip
sunflower: Skip
swarm: Skip
swipe: Skip
-third_party/todomvc/*: Skip
+third_party/todomvc: Skip
[ $compiler == dart2js && $browser ]
dartcombat/test/dartcombat_test: Skip
-third_party/todomvc/*: Skip # Issue 12865
[ $compiler == dart2js && $runtime == none ]
*: Fail, Pass # TODO(ahe): Triage these tests.

Powered by Google App Engine
This is Rietveld 408576698