content/public/common/key_system_info.cc - Issue 23678008: Refactor KeySystems code to call a function to populate the info.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/public/common/key_system_info.cc

Issue 23678008: Refactor KeySystems code to call a function to populate the info. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: scherkus review updates Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« content/public/common/key_system_info.h ('K') | « content/public/common/key_system_info.h ('k') | content/renderer/media/crypto/key_systems.h » ('j') | content/renderer/media/crypto/key_systems_info.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "content/public/browser/javascript_dialog_manager.h"	5 #include "content/public/common/key_system_info.h"

6	6

7 namespace content {	7 namespace content {

8	8

9 bool JavaScriptDialogManager::HandleJavaScriptDialog(	9 KeySystemInfo::KeySystemInfo(const std::string& key_system)
	jam 2013/09/03 20:50:52 nit: if you can inline this constructor in the hea nit: if you can inline this constructor in the header and get rid of the cc file, that's preferred. the reason you wouldn't be able to is clang, but it has some heuristics that i don't know off the top of my head. so please try that and see if you get green try runs. also no need for destructor? ddorwin 2013/09/04 00:41:55 Clang is unhappy: ../../content/public/renderer/k Show quoted text On 2013/09/03 20:50:52, jam wrote: > nit: if you can inline this constructor in the header and get rid of the cc > file, that's preferred. the reason you wouldn't be able to is clang, but it has > some heuristics that i don't know off the top of my head. so please try that and > see if you get green try runs. > > also no need for destructor? Clang is unhappy: ../../content/public/renderer/key_system_info.h:37:3: error: [chromium-style] Complex constructor has an inlined body. explicit KeySystemInfo(const std::string& key_system) ^ ../../content/public/renderer/key_system_info.h:34:1: error: [chromium-style] Complex class/struct needs an explicit out-of-line destructor. struct CONTENT_EXPORT KeySystemInfo { ^
10 WebContents* web_contents,	10 : key_system(key_system),

11 bool accept,	11 use_aes_decryptor(false) {

12 const string16* prompt_override) {	12 }

13 return false;	13

	14 KeySystemInfo::~KeySystemInfo() {

14 }	15 }

15	16

16 } // namespace content	17 } // namespace content

OLD	NEW