Issue 23678005: DevTools: migrate from scale to max size parameters in capture screen.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23678005: DevTools: migrate from scale to max size parameters in capture screen. (Closed)

Created:
7 years, 3 months ago by pfeldman

Modified:
7 years, 3 months ago

Reviewers:
vsevik

CC:
chromium-reviews, vsevik, jam, yurys, joi+watch-content_chromium.org, paulirish+reviews_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

DevTools: migrate from scale to max size parameters in capture screen. R=vsevik@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220575

Patch Set 1 #

Patch Set 2 : Same with migration to dip in protocol. #

Patch Set 3 : #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+63 lines, -50 lines)			Patch
M	content/browser/devtools/devtools_protocol_constants.h	View		1 chunk	+2 lines, -4 lines	0 comments	Download
M	content/browser/devtools/devtools_protocol_constants.cc	View		1 chunk	+2 lines, -4 lines	0 comments	Download
M	content/browser/devtools/renderer_overrides_handler.h	View		3 chunks	+5 lines, -0 lines	0 comments	Download
M	content/browser/devtools/renderer_overrides_handler.cc	View	1	7 chunks	+54 lines, -42 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pfeldman@chromium.org/23678005/7001

7 years, 3 months ago (2013-08-30 13:07:21 UTC) #3

pfeldman

7 years, 3 months ago (2013-08-30 13:45:31 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r220575 (presubmit successful).

Expand Messages | Collapse Messages