Worker: Notify WorkerReportingProxy::didInitializeWorkerContext() immediately after initialization

Worker: Notify WorkerReportingProxy::didInitializeWorkerContext() immediately after initialization

Before this CL, WorkerReportingProxy::didInitializeWorkerContext() is notified
after debugger tasks may run. This looks strange. The function should be called
immediately after the context initialization.

BUG=640843
Committed: https://crrev.com/845fdc5871ba99d69966175052eb297e4c76b037
Cr-Commit-Position: refs/heads/master@{#422032}

[nhiroki, 2016-09-23 13:32:48]

The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-23 13:32:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nhiroki, 2016-09-23 13:35:53]

Description was changed from

==========
Worker: Notify WorkerReportingProxy::didInitializeWorkerContext() immediately
after initialziation

BUG=640843
==========

to

==========
Worker: Notify WorkerReportingProxy::didInitializeWorkerContext() immediately
after initialziation

Before this CL, WorkerReportingProxy::didInitializeWorkerContext() is notified
after debugger tasks may run. This looks strange. The function should be called
immediately after the context initialization.

BUG=640843
==========

[nhiroki, 2016-09-23 13:45:58]

nhiroki@chromium.org changed reviewers:
+ falken@chromium.org, yhirano@chromium.org

[nhiroki, 2016-09-23 13:45:59]

PTAL, thanks!

[nhiroki, 2016-09-23 13:46:18]

Description was changed from

==========
Worker: Notify WorkerReportingProxy::didInitializeWorkerContext() immediately
after initialziation

Before this CL, WorkerReportingProxy::didInitializeWorkerContext() is notified
after debugger tasks may run. This looks strange. The function should be called
immediately after the context initialization.

BUG=640843
==========

to

==========
Worker: Notify WorkerReportingProxy::didInitializeWorkerContext() immediately
after initialization

Before this CL, WorkerReportingProxy::didInitializeWorkerContext() is notified
after debugger tasks may run. This looks strange. The function should be called
immediately after the context initialization.

BUG=640843
==========

[commit-bot: I haz the power, 2016-09-23 13:47:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 13:47:20]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[falken, 2016-09-26 01:27:24]

lgtm

I was going to suggest bug 519111 but I see that's already been duped.

[yhirano, 2016-09-26 01:34:32]

https://codereview.chromium.org/2367783003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/workers/WorkerThread.cpp (right):

https://codereview.chromium.org/2367783003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/workers/WorkerThread.cpp:503: if
(globalScope()->scriptController()->isContextInitialized()) {
Can this isContextInitialized call be replaced with evaluating the return value
of initializeContextIfNeeded? Also, adding a comment to
initializeContextIfNeeded about its return value would be helpful.

[nhiroki, 2016-09-30 04:04:20]

Thank you! Updated.

https://codereview.chromium.org/2367783003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/workers/WorkerThread.cpp (right):

https://codereview.chromium.org/2367783003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/workers/WorkerThread.cpp:503: if
(globalScope()->scriptController()->isContextInitialized()) {
On 2016/09/26 01:34:32, yhirano wrote:
> Can this isContextInitialized call be replaced with evaluating the return
value
> of initializeContextIfNeeded? Also, adding a comment to
> initializeContextIfNeeded about its return value would be helpful.

Done.

[nhiroki, 2016-09-30 04:04:31]

The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-30 04:04:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yhirano, 2016-09-30 04:06:11]

lgtm

[nhiroki, 2016-09-30 04:55:30]

The CQ bit was checked by nhiroki@chromium.org

[nhiroki, 2016-09-30 04:55:31]

The CQ bit was unchecked by nhiroki@chromium.org

[nhiroki, 2016-09-30 04:55:31]

The patchset sent to the CQ was uploaded after l-g-t-m from falken@chromium.org
Link to the patchset: https://codereview.chromium.org/2367783003/#ps40001
(title: "add comments")

[commit-bot: I haz the power, 2016-09-30 04:55:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-30 05:02:52]

Description was changed from

==========
Worker: Notify WorkerReportingProxy::didInitializeWorkerContext() immediately
after initialization

Before this CL, WorkerReportingProxy::didInitializeWorkerContext() is notified
after debugger tasks may run. This looks strange. The function should be called
immediately after the context initialization.

BUG=640843
==========

to

==========
Worker: Notify WorkerReportingProxy::didInitializeWorkerContext() immediately
after initialization

Before this CL, WorkerReportingProxy::didInitializeWorkerContext() is notified
after debugger tasks may run. This looks strange. The function should be called
immediately after the context initialization.

BUG=640843
==========

[commit-bot: I haz the power, 2016-09-30 05:02:53]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-30 05:04:12]

Description was changed from

==========
Worker: Notify WorkerReportingProxy::didInitializeWorkerContext() immediately
after initialization

Before this CL, WorkerReportingProxy::didInitializeWorkerContext() is notified
after debugger tasks may run. This looks strange. The function should be called
immediately after the context initialization.

BUG=640843
==========

to

==========
Worker: Notify WorkerReportingProxy::didInitializeWorkerContext() immediately
after initialization

Before this CL, WorkerReportingProxy::didInitializeWorkerContext() is notified
after debugger tasks may run. This looks strange. The function should be called
immediately after the context initialization.

BUG=640843

Committed: https://crrev.com/845fdc5871ba99d69966175052eb297e4c76b037
Cr-Commit-Position: refs/heads/master@{#422032}
==========

[commit-bot: I haz the power, 2016-09-30 05:04:13]

Patchset 3 (id:??) landed as
https://crrev.com/845fdc5871ba99d69966175052eb297e4c76b037
Cr-Commit-Position: refs/heads/master@{#422032}