Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 2367743003: Clean CPDF_CIDFont a little (Closed)

Created:
4 years, 2 months ago by npm
Modified:
4 years, 2 months ago
Reviewers:
Lei Zhang, dsinclair, Wei Li
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Clean CPDF_CIDFont a little Remove C-casts, nits. Committed: https://pdfium.googlesource.com/pdfium/+/b4d7c682bd47f12cb16a5c5c523f58ea0742c730

Patch Set 1 #

Patch Set 2 : Evil winbots #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -44 lines) Patch
M core/fpdfapi/fpdf_font/cpdf_cidfont.cpp View 1 12 chunks +34 lines, -44 lines 0 comments Download

Messages

Total messages: 18 (12 generated)
npm
PTAL
4 years, 2 months ago (2016-09-23 19:29:53 UTC) #5
Lei Zhang
Got red bots.
4 years, 2 months ago (2016-09-23 20:29:50 UTC) #8
npm
Fixed bots
4 years, 2 months ago (2016-09-23 20:53:37 UTC) #13
Lei Zhang
lgtm
4 years, 2 months ago (2016-09-23 20:55:38 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2367743003/20001
4 years, 2 months ago (2016-09-23 20:57:09 UTC) #16
commit-bot: I haz the power
4 years, 2 months ago (2016-09-23 20:57:28 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/b4d7c682bd47f12cb16a5c5c523f58ea0742...

Powered by Google App Engine
This is Rietveld 408576698