Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Unified Diff: chrome/browser/chromeos/extensions/device_local_account_management_policy_provider.cc

Issue 2367733002: Sorted kSafeManifestEntries array (cleanup only, no real changes) (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/extensions/device_local_account_management_policy_provider.cc
diff --git a/chrome/browser/chromeos/extensions/device_local_account_management_policy_provider.cc b/chrome/browser/chromeos/extensions/device_local_account_management_policy_provider.cc
index e0b1c08fbfea7504256b791470fcc1abbf302da2..aa34d1738bce9562ba6e16443ef210fbc399a878 100644
--- a/chrome/browser/chromeos/extensions/device_local_account_management_policy_provider.cc
+++ b/chrome/browser/chromeos/extensions/device_local_account_management_policy_provider.cc
@@ -127,31 +127,6 @@ const char* const kSafeManifestEntries[] = {
// Special-cased in IsPlatformAppSafeForPublicSession().
// emk::kApp,
- // Special-cased in IsPlatformAppSafeForPublicSession().
- // emk::kManifestVersion,
-
- // Just a display string.
- emk::kName,
-
- // Just a display string.
- emk::kShortName,
-
- // Version string (for app updates).
- emk::kVersion,
-
- // Name of directory containg default strings.
- emk::kDefaultLocale,
-
- // An implementation detail (actually written by Chrome, not the app
- // author).
- emk::kCurrentLocale,
-
- // Just a display string.
- emk::kDescription,
-
- // Just UX.
- emk::kIcons,
-
// Documented in https://developer.chrome.com/extensions/manifest but not
// implemented anywhere. Still, a lot of apps use it.
"author",
@@ -162,9 +137,22 @@ const char* const kSafeManifestEntries[] = {
// TBD
// emk::kCommands,
+ // An implementation detail (actually written by Chrome, not the app
+ // author).
+ emk::kCurrentLocale,
+
+ // Name of directory containg default strings.
+ emk::kDefaultLocale,
+
+ // Just a display string.
+ emk::kDescription,
+
// TBD, looks unsafe
// emk::kEventRules,
+ // Shared Modules configuration: Allow other extensions to access resources.
+ emk::kExport,
+
// TBD
// emk::kExternallyConnectable,
@@ -174,12 +162,12 @@ const char* const kSafeManifestEntries[] = {
// TBD
// emk::kFileSystemProviderCapabilities,
+ // Just UX.
+ emk::kIcons,
+
// Shared Modules configuration: Import resources from another extension.
emk::kImport,
- // Shared Modules configuration: Allow other extensions to access resources.
- emk::kExport,
-
// Shared Modules configuration: Specify extension id for development.
emk::kKey,
@@ -189,6 +177,9 @@ const char* const kSafeManifestEntries[] = {
// Contradicts the purpose of running inside a Public Session.
// emk::kKioskOnly,
+ // Special-cased in IsPlatformAppSafeForPublicSession().
+ // emk::kManifestVersion,
+
// Descriptive statement about the app.
emk::kMinimumChromeVersion,
@@ -196,6 +187,9 @@ const char* const kSafeManifestEntries[] = {
// and thus should not pose a risk.
emk::kNaClModules,
+ // Just a display string.
+ emk::kName,
+
// TBD, doc missing
// emk::kOAuth2,
@@ -218,6 +212,9 @@ const char* const kSafeManifestEntries[] = {
// since extensions::manifest_keys only has constants for sub-keys.)
"sandbox",
+ // Just a display string.
+ emk::kShortName,
+
// TBD, doc missing
// emk::kSignature,
@@ -245,6 +242,9 @@ const char* const kSafeManifestEntries[] = {
// TBD
// emk::kUsbPrinters,
+ // Version string (for app updates).
+ emk::kVersion,
+
// Just a display string.
emk::kVersionName,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698