Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2367733002:
Sorted kSafeManifestEntries array (cleanup only, no real changes) (Closed)
|
Created:
4 years, 3 months ago by Ivan Šandrk Modified:
4 years, 2 months ago CC:
chromium-reviews, chromium-apps-reviews_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org, extensions-reviews_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionSorted kSafeManifestEntries array (cleanup only, no real changes)
BUG=649726
Committed: https://crrev.com/4758f88382896d80b6a2b52a50cd323b674c58e4
Cr-Commit-Position: refs/heads/master@{#420904}
Patch Set 1 #
Messages
Total messages: 24 (13 generated)
isandrk@chromium.org changed reviewers: + tnagel@chromium.org
Hi Thiemo, ptal! Thanks, Ivan
The CQ bit was checked by isandrk@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
rubberstamp LGTM but please include the bug number in the CL description (The real review will be for the follow-up CL to ensure compliance with the source of truth, the spreadshirt.)
Description was changed from ========== Sorted kSafeManifestEntries array (cleanup only, no real changes) BUG= ========== to ========== Sorted kSafeManifestEntries array (cleanup only, no real changes) BUG=633301 ==========
isandrk@chromium.org changed reviewers: + bartfab@chromium.org
On 2016/09/23 15:38:10, Ivan Šandrk wrote: > mailto:isandrk@chromium.org changed reviewers: > + mailto:bartfab@chromium.org Hi Bartosz, I need a rubberstamp LGTM. Thanks, Ivan
Please don't use the launch bug to land CLs. Could you please create a bug for the implementation and reference it here?
Description was changed from ========== Sorted kSafeManifestEntries array (cleanup only, no real changes) BUG=633301 ========== to ========== Sorted kSafeManifestEntries array (cleanup only, no real changes) BUG=649726 ==========
On 2016/09/23 16:01:03, Thiemo Nagel (ooo) wrote: > Please don't use the launch bug to land CLs. Could you please create a bug for > the implementation and reference it here? Done!
lgtm
The CQ bit was checked by isandrk@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #2 (id:20001) has been deleted
The CQ bit was checked by isandrk@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Sorted kSafeManifestEntries array (cleanup only, no real changes) BUG=649726 ========== to ========== Sorted kSafeManifestEntries array (cleanup only, no real changes) BUG=649726 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Sorted kSafeManifestEntries array (cleanup only, no real changes) BUG=649726 ========== to ========== Sorted kSafeManifestEntries array (cleanup only, no real changes) BUG=649726 Committed: https://crrev.com/4758f88382896d80b6a2b52a50cd323b674c58e4 Cr-Commit-Position: refs/heads/master@{#420904} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/4758f88382896d80b6a2b52a50cd323b674c58e4 Cr-Commit-Position: refs/heads/master@{#420904} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
