Issue 236773003: Completely remove DOMRequestState from IndexedDB code

Issue 236773003: Completely remove DOMRequestState from IndexedDB code (Closed)

Created:
6 years, 8 months ago by haraken

Modified:
6 years, 8 months ago

Reviewers:
dcarney, jochen (gone - plz use gerrit), jsbell

CC:
blink-reviews, Nils Barth (inactive), jsbell+idb_chromium.org, arv+blink, jsbell+bindings_chromium.org, alecflett, sof, kouhei+bindings_chromium.org, ericu+idb_chromium.org, abarth-chromium, marja+watch_chromium.org, dgrogan, adamk+blink_chromium.org, cmumford, haraken, Nate Chapin, Inactive

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Completely remove DOMRequestState from IndexedDB code Currently we have a lot of DOMRequestStates in IndexedDB code. However, the only object where we really need a script state is IDBRequest. Other objects just need v8::Isolate. Thus: - This CL replaces DOMRequestState in IDBRequest with NewScriptState. - This CL replaces other DOMRequestState with v8::Isolate. BUG=357144 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171462

Patch Set 1 #

Patch Set 2 : #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+98 lines, -122 lines)			Patch
M	Source/bindings/v8/IDBBindingUtilities.h	View		2 chunks	+6 lines, -7 lines	0 comments	Download
M	Source/bindings/v8/IDBBindingUtilities.cpp	View	1	19 chunks	+41 lines, -46 lines	0 comments	Download
M	Source/bindings/v8/IDBBindingUtilitiesTest.cpp	View		7 chunks	+16 lines, -16 lines	0 comments	Download
M	Source/modules/indexeddb/IDBCursor.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/modules/indexeddb/IDBCursor.cpp	View		5 chunks	+6 lines, -8 lines	0 comments	Download
M	Source/modules/indexeddb/IDBFactory.cpp	View		1 chunk	+2 lines, -3 lines	0 comments	Download
M	Source/modules/indexeddb/IDBKeyRange.cpp	View		6 chunks	+7 lines, -13 lines	0 comments	Download
M	Source/modules/indexeddb/IDBObjectStore.cpp	View		7 chunks	+7 lines, -11 lines	0 comments	Download
M	Source/modules/indexeddb/IDBRequest.h	View		5 chunks	+4 lines, -6 lines	0 comments	Download
M	Source/modules/indexeddb/IDBRequest.cpp	View	1	8 chunks	+7 lines, -9 lines	0 comments	Download
M	Source/modules/indexeddb/IDBRequest.idl	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

haraken

PTAL. This CL completely removes DOMRequestState from the IndexedDB code base.

6 years, 8 months ago (2014-04-14 12:21:13 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/236773003/20001

6 years, 8 months ago (2014-04-14 12:45:32 UTC) #4

Message was sent while issue was closed.

Change committed as 171462

Expand Messages | Collapse Messages