Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(969)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2367723004: Add tcmalloc to GN build (Closed)

Created:
4 years, 2 months ago by zra
Modified:
4 years, 2 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+170 lines, -10 lines) Patch
M build/config/compiler/BUILD.gn View 7 chunks +28 lines, -6 lines 0 comments Download
M runtime/bin/BUILD.gn View 3 chunks +16 lines, -0 lines 0 comments Download
A third_party/tcmalloc/BUILD.gn View 1 chunk +124 lines, -0 lines 0 comments Download
M third_party/tcmalloc/tcmalloc_sources.gypi View 2 chunks +0 lines, -4 lines 0 comments Download
M tools/gn.py View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
zra
4 years, 2 months ago (2016-09-23 22:09:53 UTC) #2
Cutch
LGTM after removing the .packages file https://codereview.chromium.org/2367723004/diff/1/runtime/observatory/.packages File runtime/observatory/.packages (right): https://codereview.chromium.org/2367723004/diff/1/runtime/observatory/.packages#newcode1 runtime/observatory/.packages:1: # Generated by ...
4 years, 2 months ago (2016-09-23 22:18:01 UTC) #3
zra
Committed patchset #2 (id:20001) manually as 27784381b2e490de6bf2871b5196620d1831fb90 (presubmit successful).
4 years, 2 months ago (2016-09-23 22:24:58 UTC) #5
zra
4 years, 2 months ago (2016-09-23 22:25:05 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/2367723004/diff/1/runtime/observatory/.packages
File runtime/observatory/.packages (right):

https://codereview.chromium.org/2367723004/diff/1/runtime/observatory/.packag...
runtime/observatory/.packages:1: # Generated by pub on 2016-09-23
14:36:10.810545.
On 2016/09/23 22:18:01, Cutch wrote:
> This file shouldn't be part of the CL.

Done.

Powered by Google App Engine
This is Rietveld 408576698