Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2733)

Unified Diff: Source/web/WebViewImpl.cpp

Issue 23677012: Tell the root layer it has a wheel handler when a select is active (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/WebViewImpl.cpp
diff --git a/Source/web/WebViewImpl.cpp b/Source/web/WebViewImpl.cpp
index 3cd8a54068bd35a1e95930c193eb081fc28904e9..d218728aa3f0acd09cdcb0110d99d7c8f644d03a 100644
--- a/Source/web/WebViewImpl.cpp
+++ b/Source/web/WebViewImpl.cpp
@@ -1531,6 +1531,7 @@ void WebViewImpl::popupOpened(WebCore::PopupContainer* popupContainer)
if (popupContainer->popupType() == WebCore::PopupContainer::Select) {
ASSERT(!m_selectPopup);
m_selectPopup = popupContainer;
+ m_rootLayer->setHaveWheelEventHandlers(true);
}
}
@@ -1539,6 +1540,7 @@ void WebViewImpl::popupClosed(WebCore::PopupContainer* popupContainer)
if (popupContainer->popupType() == WebCore::PopupContainer::Select) {
ASSERT(m_selectPopup);
m_selectPopup = 0;
+ m_rootLayer->setHaveWheelEventHandlers(false);
jamesr 2013/09/20 18:04:10 what if the root layer actually had wheel event ha
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698