Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 23677012: Tell the root layer it has a wheel handler when a select is active (Closed)

Created:
7 years, 3 months ago by scottmg
Modified:
7 years, 3 months ago
Reviewers:
jamesr
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Tell the root layer it has a wheel handler when a select is open Otherwise, the input events are handled in content::InputHandlerProxy::HandleInputEvent and not forwarded to the renderer, so the select popup is not closed when wheeling over the main content. R=jamesr@chromium.org BUG=294506 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158148

Patch Set 1 #

Total comments: 1

Patch Set 2 : use WheelController instead #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M Source/web/WebViewImpl.cpp View 1 3 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
scottmg
7 years, 3 months ago (2013-09-20 17:45:28 UTC) #1
jamesr
https://codereview.chromium.org/23677012/diff/1/Source/web/WebViewImpl.cpp File Source/web/WebViewImpl.cpp (right): https://codereview.chromium.org/23677012/diff/1/Source/web/WebViewImpl.cpp#newcode1543 Source/web/WebViewImpl.cpp:1543: m_rootLayer->setHaveWheelEventHandlers(false); what if the root layer actually had wheel ...
7 years, 3 months ago (2013-09-20 18:04:10 UTC) #2
scottmg
Thanks, using WheelController seems best so that it doesn't collide with scrollable areas changing.
7 years, 3 months ago (2013-09-20 18:32:01 UTC) #3
jamesr
lgtm
7 years, 3 months ago (2013-09-20 18:33:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/23677012/1002
7 years, 3 months ago (2013-09-20 18:49:32 UTC) #5
commit-bot: I haz the power
7 years, 3 months ago (2013-09-21 01:44:51 UTC) #6
Message was sent while issue was closed.
Change committed as 158148

Powered by Google App Engine
This is Rietveld 408576698