Byte-swap the video frame pixels before passing them to Java.

remoting/client/frame_consumer_proxy.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/client/frame_consumer_proxy.h"
 
 #include "base/bind.h"
 #include "base/location.h"
 #include "base/single_thread_task_runner.h"
 #include "third_party/webrtc/modules/desktop_capture/desktop_frame.h"
@@ skipping 39 matching lines @@
   if (!task_runner_->BelongsToCurrentThread()) {
     task_runner_->PostTask(FROM_HERE, base::Bind(
         &FrameConsumerProxy::SetSourceSize, this, source_size, source_dpi));
     return;
   }
 
   if (frame_consumer_.get())
     frame_consumer_->SetSourceSize(source_size, source_dpi);
 }
 
+FrameConsumer::PixelFormat FrameConsumerProxy::GetPixelFormat() {
+  return pixel_format_;

[Sergey Ulanov, 2013/09/27 21:51:13]

This value is set on a different thread. It's not safe to read it here without a
lock. In the same time I don't think a lock is the right solution. I suggest the
following: 
 - Remove Attach() method and instead pass frame_consumer in the constructor.
Then it will be safe to read this value here without a lock.
 - In ChromotingInstance::ConnectWithConfig() you will need to create PepperView
(which is a FrameConsumer) before creating FrameConsumerProxy, but you need the
FrameConsumerProxy to create the client (which contains FrameProducer). This can
be solved by removing |producer| parameter from PepperView constructor. Instead
move it to the InitiateDrawing() method and call that method explicitly after
Client is created.

Currently objects are created in the following order: ConsumerProxy,
ChromotingClient (with RectangleUpdateDecoder), PepperView.
My suggestion above is essentially to change that order to the following:
PepperView, ConsumerProxy, ChromotingClient (with RectangleUpdateDecoder).

[Lambros, 2013/09/28 00:22:18]

Done.

+}
+
 void FrameConsumerProxy::Attach(
     const base::WeakPtr<FrameConsumer>& frame_consumer) {
   DCHECK(task_runner_->BelongsToCurrentThread());
   DCHECK(frame_consumer_.get() == NULL);
   frame_consumer_ = frame_consumer;
+
+  pixel_format_ = frame_consumer_->GetPixelFormat();
 }
 
 FrameConsumerProxy::~FrameConsumerProxy() {
 }
 
 }  // namespace remoting