Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(683)

Side by Side Diff: remoting/client/frame_consumer.h

Issue 23677011: Byte-swap the video frame pixels before passing them to Java. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add PixelFormat to FrameConsumer interface Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef REMOTING_CLIENT_FRAME_CONSUMER_H_ 5 #ifndef REMOTING_CLIENT_FRAME_CONSUMER_H_
6 #define REMOTING_CLIENT_FRAME_CONSUMER_H_ 6 #define REMOTING_CLIENT_FRAME_CONSUMER_H_
7 7
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 #include "third_party/skia/include/core/SkRect.h" 9 #include "third_party/skia/include/core/SkRect.h"
10 #include "third_party/skia/include/core/SkRegion.h" 10 #include "third_party/skia/include/core/SkRegion.h"
11 #include "third_party/skia/include/core/SkSize.h" 11 #include "third_party/skia/include/core/SkSize.h"
12 12
13 namespace webrtc { 13 namespace webrtc {
14 class DesktopFrame; 14 class DesktopFrame;
15 } // namespace webrtc 15 } // namespace webrtc
16 16
17 namespace remoting { 17 namespace remoting {
18 18
19 class FrameConsumer { 19 class FrameConsumer {
20 public: 20 public:
21
22 // List of supported pixel formats needed by various platforms.
23 enum PixelFormat {
24 FORMAT_BGRA, // Used by the Pepper plugin.
25 FORMAT_RGBA, // Used for Android's Bitmap class.
26 };
27
21 // Accepts a buffer to be painted to the screen. The buffer's dimensions and 28 // Accepts a buffer to be painted to the screen. The buffer's dimensions and
22 // relative position within the frame are specified by |clip_area|. Only 29 // relative position within the frame are specified by |clip_area|. Only
23 // pixels falling within |region| and the current clipping area are painted. 30 // pixels falling within |region| and the current clipping area are painted.
24 // The function assumes that the passed buffer was scaled to fit a window 31 // The function assumes that the passed buffer was scaled to fit a window
25 // having |view_size| dimensions. 32 // having |view_size| dimensions.
26 // 33 //
27 // N.B. Both |clip_area| and |region| are in output coordinates relative to 34 // N.B. Both |clip_area| and |region| are in output coordinates relative to
28 // the frame. 35 // the frame.
29 virtual void ApplyBuffer(const SkISize& view_size, 36 virtual void ApplyBuffer(const SkISize& view_size,
30 const SkIRect& clip_area, 37 const SkIRect& clip_area,
31 webrtc::DesktopFrame* buffer, 38 webrtc::DesktopFrame* buffer,
32 const SkRegion& region) = 0; 39 const SkRegion& region) = 0;
33 40
34 // Accepts a buffer that couldn't be used for drawing for any reason (shutdown 41 // Accepts a buffer that couldn't be used for drawing for any reason (shutdown
35 // is in progress, the view area has changed, etc.). The accepted buffer can 42 // is in progress, the view area has changed, etc.). The accepted buffer can
36 // be freed or reused for another drawing operation. 43 // be freed or reused for another drawing operation.
37 virtual void ReturnBuffer(webrtc::DesktopFrame* buffer) = 0; 44 virtual void ReturnBuffer(webrtc::DesktopFrame* buffer) = 0;
38 45
39 // Set the dimension of the entire host screen. 46 // Set the dimension of the entire host screen.
40 virtual void SetSourceSize(const SkISize& source_size, 47 virtual void SetSourceSize(const SkISize& source_size,
41 const SkIPoint& dpi) = 0; 48 const SkIPoint& dpi) = 0;
42 49
50 // Returns the preferred pixel encoding for the platform. This may be called
51 // from any thread.
Sergey Ulanov 2013/09/27 21:51:13 Don't need the threading comment. This interface i
Lambros 2013/09/28 00:22:18 Done.
52 virtual PixelFormat GetPixelFormat() = 0;
53
43 protected: 54 protected:
44 FrameConsumer() {} 55 FrameConsumer() {}
45 virtual ~FrameConsumer() {} 56 virtual ~FrameConsumer() {}
46 57
47 private: 58 private:
48 DISALLOW_COPY_AND_ASSIGN(FrameConsumer); 59 DISALLOW_COPY_AND_ASSIGN(FrameConsumer);
49 }; 60 };
50 61
51 } // namespace remoting 62 } // namespace remoting
52 63
53 #endif // REMOTING_CLIENT_FRAME_CONSUMER_H_ 64 #endif // REMOTING_CLIENT_FRAME_CONSUMER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698