Byte-swap the video frame pixels before passing them to Java.

remoting/android/java/src/org/chromium/chromoting/jni/JniInterface.java

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chromoting.jni;
 
 import android.app.Activity;
 import android.app.AlertDialog;
 import android.app.ProgressDialog;
 import android.content.Context;
@@ skipping 124 matching lines @@
      */
     /** Callback to signal whenever we need to redraw. */
     private static Runnable sRedrawCallback = null;
 
     /** Screen width of the video feed. */
     private static int sWidth = 0;
 
     /** Screen height of the video feed. */
     private static int sHeight = 0;
 
+    /** Bitmap holding the latest screen image. */
+    private static Bitmap sBitmap = null;
+
     /** Buffer holding the video feed. */
     private static ByteBuffer sBuffer = null;
 
     /** Position of cursor hot-spot. */
     private static Point sCursorHotspot = new Point();
 
     /** Bitmap holding the cursor shape. */
     private static Bitmap sCursorBitmap = null;
 
     /** Reports whenever the connection status changes. */
@@ skipping 148 matching lines @@
      */
     public static Bitmap retrieveVideoFrame() {
         if (Looper.myLooper() == Looper.getMainLooper()) {
             Log.w("jniiface", "Canvas being redrawn on UI thread");
         }
 
         if (!sConnected) {
             return null;
         }
 
-        int[] frame = new int[sWidth * sHeight];
+        // This is synchronized only to silence a findbugs warning about incorrect initialization of
+        // |sBitmap|.
+        // TODO(lambroslambrou): Annotate this class as @NotThreadSafe to prevent similar warnings
+        // in future.
+        synchronized (JniInterface.class) {
+            if (sBitmap == null || sBitmap.getWidth() != sWidth || sBitmap.getHeight() != sHeight) {
+                sBitmap = Bitmap.createBitmap(sWidth, sHeight, Bitmap.Config.ARGB_8888);
+            }
+        }
 
-        sBuffer.order(ByteOrder.LITTLE_ENDIAN);
-        sBuffer.asIntBuffer().get(frame, 0, frame.length);
-
-        return Bitmap.createBitmap(frame, 0, sWidth, sWidth, sHeight, Bitmap.Config.ARGB_8888);
+        sBuffer.rewind();
+        sBitmap.copyPixelsFromBuffer(sBuffer);
+        return sBitmap;
     }
 
     /**
      * Updates the cursor shape. This is called from native code on the graphics thread when
      * receiving a new cursor shape from the host.
      */
     public static void updateCursorShape(int width, int height, int hotspotX, int hotspotY,
                                          ByteBuffer buffer) {
         sCursorHotspot = new Point(hotspotX, hotspotY);
 
@@ skipping 26 matching lines @@
 
     /** Schedules a redraw on the native graphics thread. */
     private static native void scheduleRedrawNative();
 
     /** Passes mouse information to the native handling code. */
     private static native void mouseActionNative(int x, int y, int whichButton, boolean buttonDown);
 
     /** Passes key press information to the native handling code. */
     private static native void keyboardActionNative(int keyCode, boolean keyDown);
 }