Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Unified Diff: components/content_settings/core/common/content_settings_pattern.h

Issue 2367683002: Add metrics for paths in file scheme exceptions in content settings. (Closed)
Patch Set: Fix UMA name Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/content_settings/core/common/content_settings_pattern.h
diff --git a/components/content_settings/core/common/content_settings_pattern.h b/components/content_settings/core/common/content_settings_pattern.h
index fc7b6091f07caf7b35d29bf00adecae73e50e0e5..37022d43cadc6f18d405124fe6d352fab6c4febd 100644
--- a/components/content_settings/core/common/content_settings_pattern.h
+++ b/components/content_settings/core/common/content_settings_pattern.h
@@ -194,6 +194,10 @@ class ContentSettingsPattern {
// Returns scheme type of pattern.
ContentSettingsPattern::SchemeType GetScheme() const;
+ // True if this pattern has a non-empty path. Can only be true for patterns
msramek 2016/09/27 11:11:38 With the DCHECK, this comment should say "can only
alexmos 2016/09/27 16:06:45 Done.
+ // with file: schemes.
+ bool HasPath() const;
+
// Compares the pattern with a given |other| pattern and returns the
// |Relation| of the two patterns.
Relation Compare(const ContentSettingsPattern& other) const;

Powered by Google App Engine
This is Rietveld 408576698