tools/metrics/histograms/histograms.xml - Issue 2367683002: Add metrics for paths in file scheme exceptions in content settings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.

Issue 2367683002: Add metrics for paths in file scheme exceptions in content settings. (Closed)

Patch Set: Address review comments Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

« components/content_settings/core/browser/host_content_settings_map.cc ('K') | « components/content_settings/core/common/content_settings_pattern_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index 0a1e303f151319f2775300e4f53ae036cc5b3e60..796f0cb7b5cb511f7c2467bd437cc486c170939e 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -6809,6 +6809,34 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

</summary>

</histogram>

+<histogram name="ContentSettings.ExceptionSchemeFile.HasPath" enum="Boolean">

Ilya Sherman 2016/09/27 00:54:34 nit: Please define a custom enum, BooleanHasPath,

alexmos 2016/09/27 01:11:22 Done.

+ <owner>alexmos@chromium.org</owner>

+ <summary>

+ Records how often a content settings exception for the file: scheme has a

+ non-empty path. Recorded at browser start.

Ilya Sherman 2016/09/27 00:54:33 nit: Probably worth mentioning explicitly that thi

alexmos 2016/09/27 01:11:22 Done.

+ </summary>

+</histogram>

+<histogram name="ContentSettings.ExceptionSchemeFile.TypeWithoutPath"

+ enum="ContentType">

+ <owner>alexmos@chromium.org</owner>

+ <summary>

+ Count of how often a specific content type has a content settings exception

+ defined for a file: scheme with no path (i.e., wildcard path). Recorded at

+ browser start.

+ </summary>

+</histogram>

+<histogram name="ContentSettings.ExceptionSchemeFile.TypeWithPath"

+ enum="ContentType">

+ <owner>alexmos@chromium.org</owner>

+ <summary>

+ Count of how often a specific content type has a content settings exception

+ defined for a file: scheme with a valid, non-empty path. Recorded at browser

+ start.

+ </summary>

+</histogram>

Deprecated 2015-10-05 in Issue 433475. Histogram was used temorarily for