Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 2367653002: Exclude rest of chromeos-only API related from compiling in non-chromeos. (Closed)

Created:
4 years, 3 months ago by lazyboy
Modified:
4 years, 3 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Exclude rest of chromeos-only API related from compiling in non-chromeos. Specifically this CL moves files related to the following APIs/Natives: certificate_provider quick_unlock_private file_system_provider platform_keys_natives & enterprise.platformKeys and friends Locally, I also see linux (non-chromeos) binary size reducing by ~5.6k [1] BUG=376319 [1]: With patch: ls -al out/Release/chrome -rwxr-x--- 1 lazyboy eng 61426832 Sep 22 17:43 out/Release/chrome Without patch: ls -al out/Release/chrome -rwxr-x--- 1 lazyboy eng 61432496 Sep 22 17:44 out/Release/chrome Committed: https://crrev.com/55aecbf31f573d51a87ca2af25e25a6a4f1988cb Cr-Commit-Position: refs/heads/master@{#420729}

Patch Set 1 #

Patch Set 2 : sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -56 lines) Patch
M chrome/common/extensions/api/BUILD.gn View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/renderer/BUILD.gn View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc View 8 chunks +35 lines, -33 lines 0 comments Download
M chrome/renderer/resources/renderer_resources.grd View 3 chunks +18 lines, -18 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
lazyboy
Antony, can you take a look? Thanks.
4 years, 3 months ago (2016-09-23 01:07:08 UTC) #2
asargent_no_longer_on_chrome
lgtm w/ CL description nit: "I also see linux chromeos binary size reducing by ~5.6k" ...
4 years, 3 months ago (2016-09-23 16:35:02 UTC) #3
lazyboy
Fixed CL description, thanks Antony. +sky for chrome/renderer/* OWNERS review: chrome/renderer/BUILD.gn chrome/renderer/resources/renderer_resources.grd
4 years, 3 months ago (2016-09-23 17:32:42 UTC) #6
sky
LGTM
4 years, 3 months ago (2016-09-23 18:08:52 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2367653002/20001
4 years, 3 months ago (2016-09-23 20:58:23 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-23 21:07:48 UTC) #16
commit-bot: I haz the power
4 years, 3 months ago (2016-09-23 21:10:59 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/55aecbf31f573d51a87ca2af25e25a6a4f1988cb
Cr-Commit-Position: refs/heads/master@{#420729}

Powered by Google App Engine
This is Rietveld 408576698