Move default StyleBuilderFunctions handlers from StyleBuilder.cpp to StyleBuilderFunctions.cpp

Move default StyleBuilderFunctions handlers from StyleBuilder.cpp to StyleBuilderFunctions.cpp

Some of the StyleBuilderFunctions handlers were being defined in
StyleBuilder.cpp. This patch cleans moves them to the correct place and
makes some minor clean-ups inside (removing the unused condition check
and a redundant isPrimitiveValue check).

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171443

[Timothy Loh, 2014-04-14 07:10:16]

I don't think it make sense to pull the helper macros into a separate file since
they're only supposed to be used in StyleBuilderFunctions.cpp.tmpl, so the patch
fixes this up.

[Nils Barth (inactive), 2014-04-14 07:35:33]

LGTM.

Personally I prefer factoring macros out, even if only used in one place, since
then the template gives an overall view of the output.
However, I understand that tastse differ, and I'm happy to defer to you here.

To see where I'm coming from, consider interface_base.cpp and interface.cpp in
the bindings CG:
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

This has 43 blocks, so even though interface.cpp is 1300+ lines,
interface_base.cpp is a manageable 153 lines and it's very easy to see the
overall structure.

So I think it would look clearer with the macros separate and the body of the
template just
{{apply_*(...)}}
...

{{apply_*(...)}}
...

Anyway, thanks for the cleanup!!

[Timothy Loh, 2014-04-14 07:52:26]

The CQ bit was checked by timloh@chromium.org

[Timothy Loh, 2014-04-14 07:52:27]

On 2014/04/14 07:35:33, Nils Barth wrote:
> Personally I prefer factoring macros out, even if only used in one place,
since
> then the template gives an overall view of the output.

Gotcha. I think I prefer it this way for this file since the output structure is
quite simple (it's simply implementations of the various apply* functions).

[commit-bot: I haz the power, 2014-04-14 07:53:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/timloh@chromium.org/236763002/1

[commit-bot: I haz the power, 2014-04-14 08:50:27]

Change committed as 171443