[modules] Detect and throw exceptions for cyclic dependencies

src/objects.h

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_OBJECTS_H_
 #define V8_OBJECTS_H_
 
 #include <iosfwd>
 #include <memory>
 
@@ skipping 7932 matching lines @@
   // [[Evaluated]]: Whether this module has been evaluated. Modules
   // are only evaluated a single time.
   DECL_BOOLEAN_ACCESSORS(evaluated)
 
   // Storage for [[Evaluated]]
   DECL_INT_ACCESSORS(flags)
 
   // Embedder-specified data
   DECL_ACCESSORS(embedder_data, Object)
 
+  // Get the SharedFunctionInfo associated with the code.
+  inline SharedFunctionInfo* shared() const;
+
   // Get the ModuleInfo associated with the code.
   inline ModuleInfo* info() const;
 
+  // Compute a hash for this object.
+  inline uint32_t Hash() const;
+
   // Implementation of spec operation ModuleDeclarationInstantiation.
   // Returns false if an exception occurred during instantiation, true
   // otherwise.
   static MUST_USE_RESULT bool Instantiate(Handle<Module> module,
                                           v8::Local<v8::Context> context,
                                           v8::Module::ResolveCallback callback,
                                           v8::Local<v8::Value> callback_data);
 
   static Handle<Object> LoadExport(Handle<Module> module, Handle<String> name);
   static void StoreExport(Handle<Module> module, Handle<String> name,
@@ skipping 18 matching lines @@
 
   // The [must_resolve] argument indicates whether or not an exception should be
   // thrown if the module does not provide an export named [name].
   //
   // If [must_resolve] is true, a null result indicates an exception. If
   // [must_resolve] is false, a null result does not necessarily indicate an
   // exception, but there may be one pending.
   //
   // Currently, an exception is always thrown in the case of a cycle and in the
   // case of conflicting star exports.  TODO(neis): Make that spec-compliant.
-  static MUST_USE_RESULT MaybeHandle<Cell> ResolveExport(Handle<Module> module,
-                                                         Handle<String> name,
-                                                         bool must_resolve);
-  static MUST_USE_RESULT MaybeHandle<Cell> ResolveImport(Handle<Module> module,
-                                                         Handle<String> name,
-                                                         int module_request,
-                                                         bool must_resolve);
+  class ResolveSet;
+  static MUST_USE_RESULT MaybeHandle<Cell> ResolveExport(
+      Handle<Module> module, Handle<String> name, bool must_resolve,
+      ResolveSet* resolve_set);
+  static MUST_USE_RESULT MaybeHandle<Cell> ResolveImport(
+      Handle<Module> module, Handle<String> name, int module_request,
+      bool must_resolve, ResolveSet* resolve_set);
 
   // Helper for ResolveExport.
   static MUST_USE_RESULT MaybeHandle<Cell> ResolveExportUsingStarExports(
-      Handle<Module> module, Handle<String> name, bool must_resolve);
+      Handle<Module> module, Handle<String> name, bool must_resolve,
+      ResolveSet* resolve_set);
 
   DISALLOW_IMPLICIT_CONSTRUCTORS(Module);
 };
 
 // JSBoundFunction describes a bound function exotic object.
 class JSBoundFunction : public JSObject {
  public:
   // [bound_target_function]: The wrapped function object.
   DECL_ACCESSORS(bound_target_function, JSReceiver)
 
@@ skipping 3427 matching lines @@
     }
     return value;
   }
 };
 
 
 }  // NOLINT, false-positive due to second-order macros.
 }  // NOLINT, false-positive due to second-order macros.
 
 #endif  // V8_OBJECTS_H_