Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 2367623002: Revert of [swarming/api] Add text in to indicate whether a shard is failing (Closed)

Created:
4 years, 2 months ago by nednguyen
Modified:
4 years, 2 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org, eyaich1
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Revert of [swarming/api] Add text in to indicate whether a shard is failing (patchset #4 id:70001 of https://codereview.chromium.org/2362733002/ ) Reason for revert: All the shards are annotated as "failed" (https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/284618) Original issue's description: > [swarming/api] Add text in to indicate whether a shard is failing > > BUG=chromium:639321 > > Committed: https://chromium.googlesource.com/chromium/tools/build/+/68e74d1eef346395009cf05e4ad358c8a762dab0 TBR=kbr@chromium.org,maruel@chromium.org,vadimsh@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:639321 Committed: https://chromium.googlesource.com/chromium/tools/build/+/e33d22aee513e6e4385251d3160dc94308cbf262

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -27 lines) Patch
M scripts/slave/recipe_modules/swarming/api.py View 2 chunks +2 lines, -7 lines 0 comments Download
M scripts/slave/recipe_modules/test_utils/test_api.py View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/dynamic_swarmed_failed_isolated_script_test.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/dynamic_swarmed_isolated_script_test_linux_gpu.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/dynamic_swarmed_isolated_script_test_mac_gpu.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/dynamic_swarmed_isolated_script_test_win_gpu.json View 3 chunks +3 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/dynamic_swarmed_isolated_script_test_win_non_gpu.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/dynamic_swarmed_passed_isolated_script_test.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/dynamic_swarmed_passed_isolated_script_test_with_swarming_failure.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/dynamic_swarmed_passed_with_bad_retcode_isolated_script_test.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_failed_isolated_script_test.json View 1 chunk +3 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_script_test_harness_failure.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_script_test_missing_shard.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_passed_isolated_script_test.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/dynamic_isolated_script_test_with_args_on_trybot.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
nednguyen
Created Revert of [swarming/api] Add text in to indicate whether a shard is failing
4 years, 2 months ago (2016-09-23 00:50:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2367623002/1
4 years, 2 months ago (2016-09-23 00:50:41 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 2 months ago (2016-09-23 00:50:43 UTC) #5
M-A Ruel
lgtm
4 years, 2 months ago (2016-09-23 01:10:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2367623002/1
4 years, 2 months ago (2016-09-23 01:22:20 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-09-23 01:22:34 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/e33d22aee513e6e43852...

Powered by Google App Engine
This is Rietveld 408576698